Date: Mon, 31 Oct 2011 04:25:26 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Marius Strobl <marius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226947 - in head/sys: dev/esp sparc64/sbus Message-ID: <20111031042526.GA57014@FreeBSD.org> In-Reply-To: <201110302117.p9ULHgLD085245@svn.freebsd.org> References: <201110302117.p9ULHgLD085245@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Oct 30, 2011 at 09:17:42PM +0000, Marius Strobl wrote: > Author: marius > Date: Sun Oct 30 21:17:42 2011 > New Revision: 226947 > URL: http://svn.freebsd.org/changeset/base/226947 > > Log: > - Use device_t rather than the NetBSDish struct device. Hmm, I though that style(9) advises against this practice: Avoid using typedefs for structure types. Typedefs are problematic because they do not properly hide their underlying type; [...] When convention requires a typedef, make its name match the struct tag. Avoid typedefs ending in _t, except as specified in Standard C or by POSIX. Does these rules not apply for struct device for some reason? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111031042526.GA57014>