Date: Thu, 15 Jul 2004 19:35:24 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c Message-ID: <20040715173524.GG12007@darkness.comp.waw.pl> In-Reply-To: <Pine.NEB.3.96L.1040715131957.67360D-100000@fledge.watson.org> References: <20040715170320.GF12007@darkness.comp.waw.pl> <Pine.NEB.3.96L.1040715131957.67360D-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--rXoc3kw+CNDOk2Sr Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 15, 2004 at 01:21:09PM -0400, Robert Watson wrote: +> > Could we change 'td->td_ucred->cr_ruid !=3D 0 || jailed(td->td_ucred)'= to +> > 'suser(td) !=3D 0'? +>=20 +> No, because suser(td) checks the effective uid, not the real uid. Which +> is the reason I asked him to change it to that before committing, and why +> Colin had to back out his commit also :-). Colin is preparing patches to +> add a flag to suser_cred() to allow the caller to say they care about the +> real uid.=20 Thanks for clarification, but why actually do we care so much here about real uid? --=20 Pawel Jakub Dawidek http://www.FreeBSD.org pjd@FreeBSD.org http://garage.freebsd.pl FreeBSD committer Am I Evil? Yes, I Am! --rXoc3kw+CNDOk2Sr Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA9sBcForvXbEpPzQRAglrAJ9uV74GBh98Oy9x81T4lraDi2gXWwCcDHIz +dXA1ejgshnxabDbX51w6xs= =Jf0J -----END PGP SIGNATURE----- --rXoc3kw+CNDOk2Sr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040715173524.GG12007>