Date: Wed, 25 Jun 2025 19:48:12 +0000 (UTC) From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net> To: Mark Millard <marklmi@yahoo.com> Cc: Andrew Turner <andrew@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 288ba78edcfd - main - dev/psci: Check for functions before calling Message-ID: <3s789nos-rq00-6n4q-46pq-280r4n3q22q6@yvfgf.mnoonqbm.arg> In-Reply-To: <60E32387-B0BA-4ADD-A897-DC988136D2F9@yahoo.com> References: <60E32387-B0BA-4ADD-A897-DC988136D2F9.ref@yahoo.com> <60E32387-B0BA-4ADD-A897-DC988136D2F9@yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 25 Jun 2025, Mark Millard wrote: > Andrew Turner <andrew_at_FreeBSD.org> wrote on > Date: Wed, 25 Jun 2025 11:22:51 UTC : > >> The branch main has been updated by andrew: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=288ba78edcfd82b4b558a46fae78e4076acbe200 >> >> commit 288ba78edcfd82b4b558a46fae78e4076acbe200 >> Author: Andrew Turner <andrew@FreeBSD.org> >> AuthorDate: 2025-06-24 16:47:28 +0000 >> Commit: Andrew Turner <andrew@FreeBSD.org> >> CommitDate: 2025-06-24 17:45:42 +0000 >> >> dev/psci: Check for functions before calling >> >> In the SMCCC TRNG and Errata ABI drivers check if the version >> functions are implemented before calling them. Without this the firmware >> may complain about an unimplemented function being called. >> >> Reported by: bz >> Reviewed by: bz >> Sponsored by: Arm Ltd >> Differential Revision: https://reviews.freebsd.org/D50978 >> --- > > > I wonder if a debug mode or verbose mode should report > the != SMCCC_RET_SUCCESS cases for smccc_arch_features. > If this change had already been in place, the older > status might not have been noticed. As bz wrote > elsewhere: > > "That said seems like it's still a good idea to add > these bits to my TF-A." > > Having a way to check on if a TF-A instance is too > old to have a known status for handling things that > are now requested could be a good thing. Please read the comments on the review. -- Bjoern A. Zeeb r15:7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3s789nos-rq00-6n4q-46pq-280r4n3q22q6>