Date: Tue, 8 Jun 2004 02:17:43 -0500 (CDT) From: Mark Linimon <linimon@lonesome.com> To: FreeBSD-gnats-submit@FreeBSD.org Cc: portmgr@FreeBSD.org Subject: ports/67705: [patch] change handling of unsuitable MySQL versions from BROKEN to IGNORE Message-ID: <200406080717.i587Hhch019822@lonesome.lonesome.com> Resent-Message-ID: <200406080720.i587KK7C069831@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 67705
>Category: ports
>Synopsis: [patch] change handling of unsuitable MySQL versions from BROKEN to IGNORE
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Jun 08 07:20:20 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator: Mark Linimon
>Release: FreeBSD 4.9-PRERELEASE i386
>Organization:
Lonesome Dove Computing Services
>Environment:
System: FreeBSD lonesome.lonesome.com 4.9-PRERELEASE FreeBSD 4.9-PRERELEASE #3: Thu Jan 22 20:41:05 CST 2004 root@lonesome.lonesome.com:/usr/src/sys/compile/MULTIMEDIA i386
>Description:
There are a number of ports that only work with certain versions
of MySQL. There are Makevars in bsd.port.mk that a port's Makefile
can set to indicate this. However, the logic in bsd.port.mk sets
the (internal) BROKEN Makevar -- not IGNORE -- and thus bento
attempts to build the port with the default MySQL, although this
build can never succeed. The second-order effect is that portsmon
will include these ports in the periodic email to maintainers
reminding them about their broken ports, and this email is actually
spurious.
>How-To-Repeat:
cd databases/mysqlcc (or databases/mysql-administrator); make -V BROKEN
>Fix:
The following patch to bsd.port.mk fixes the problem. I will
leave it up to portmgr discretion about whether the Makevar
itself should be renamed.
Index: bsd.port.mk
===================================================================
RCS file: /home/FreeBSD/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.490
diff -u -r1.490 bsd.port.mk
--- bsd.port.mk 31 May 2004 18:07:57 -0000 1.490
+++ bsd.port.mk 8 Jun 2004 07:04:40 -0000
@@ -1492,7 +1502,7 @@
.if defined(BROKEN_WITH_MYSQL)
. for VER in ${BROKEN_WITH_MYSQL}
. if (${MYSQL_VER} == "${VER}")
-BROKEN= "Doesn't work with MySQL version : ${MYSQL_VER} (Doesn't support MySQL ${BROKEN_WITH_MYSQL})"
+IGNORE= "Doesn't work with MySQL version : ${MYSQL_VER} (Doesn't support MySQL ${BROKEN_WITH_MYSQL})"
. endif
. endfor
.endif # BROKEN_WITH_MYSQL
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406080717.i587Hhch019822>