Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Jun 2010 00:55:22 +0000 (UTC)
From:      Matt Jacob <mjacob@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r208808 - head/sys/dev/isp
Message-ID:  <201006050055.o550tMuA064798@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjacob
Date: Sat Jun  5 00:55:21 2010
New Revision: 208808
URL: http://svn.freebsd.org/changeset/base/208808

Log:
  I was getting panics in sleepq_add for the second sleep in isp_kthread.
  I don't know why- but it occurred to me in looking at the second sleep
  is that all I want is a pause- not an actual sleep. So do that instead.
  
  MFC after:	2 weeks

Modified:
  head/sys/dev/isp/isp_freebsd.c

Modified: head/sys/dev/isp/isp_freebsd.c
==============================================================================
--- head/sys/dev/isp/isp_freebsd.c	Fri Jun  4 17:54:30 2010	(r208807)
+++ head/sys/dev/isp/isp_freebsd.c	Sat Jun  5 00:55:21 2010	(r208808)
@@ -4139,7 +4139,9 @@ isp_kthread(void *arg)
 		 */
 		if (slp == 0 && fc->hysteresis) {
 			isp_prt(isp, ISP_LOGSANCFG|ISP_LOGDEBUG0, "%s: Chan %d sleep hysteresis ticks %d", __func__, chan, fc->hysteresis * hz);
-			(void) msleep(&isp_fabric_hysteresis, &isp->isp_osinfo.lock, PRIBIO, "ispT", (fc->hysteresis * hz));
+			mtx_unlock(&isp->isp_osinfo.lock);
+			pause("ispt", fc->hysteresis * hz);
+			mtx_lock(&isp->isp_osinfo.lock);
 		}
 	}
 	mtx_unlock(&isp->isp_osinfo.lock);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006050055.o550tMuA064798>