Date: Thu, 28 Oct 2021 18:22:32 +0200 From: Kristof Provost <kp@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 62d2dcafb7f3 - main - if_epair: delete mbuf tags Message-ID: <F69176B9-0A4B-4A31-96B4-DA16B42EA256@FreeBSD.org> In-Reply-To: <451456f3-6a1f-78b3-4c34-01c6cf681cd0@FreeBSD.org> References: <202110280850.19S8ocCH079483@gitrepo.freebsd.org> <451456f3-6a1f-78b3-4c34-01c6cf681cd0@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 Oct 2021, at 17:45, John Baldwin wrote: > On 10/28/21 1:50 AM, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=62d2dcafb7f33fe8f47e9d5dd519d665f7af140e >> >> commit 62d2dcafb7f33fe8f47e9d5dd519d665f7af140e >> Author: Kristof Provost <kp@FreeBSD.org> >> AuthorDate: 2021-10-26 07:57:56 +0000 >> Commit: Kristof Provost <kp@FreeBSD.org> >> CommitDate: 2021-10-28 08:41:16 +0000 >> >> if_epair: delete mbuf tags >> Remove all (non-persistent) tags when we transmit a packet. Real network >> interfaces do not carry any tags either, and leaving tags attached can >> produce unexpected results. >> Reviewed by: bz, glebius >> MFC after: 3 weeks >> Sponsored by: Rubicon Communications, LLC ("Netgate") >> Differential Revision: https://reviews.freebsd.org/D32663 > > Wireguard has similar functionality FWIW, so it might be worth exposing a generic > "mb_free_tags". Wireguard also tries to reset some other state like the status > of checksum offload since it is moving mbufs between an ifnet and a socket. Not > sure if epair also needs to clear all the same things? > Something like https://reviews.freebsd.org/D32710 ? I stuck with the ‘clear’ terminology to distinguish it from the existing free functions, and because the use case is slightly different. Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F69176B9-0A4B-4A31-96B4-DA16B42EA256>