Date: Tue, 10 Sep 2002 09:22:42 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Juli Mallett <jmallett@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen siglist.c Message-ID: <XFMail.20020910092242.jhb@FreeBSD.org> In-Reply-To: <20020909195303.B752@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10-Sep-2002 Juli Mallett wrote: > * De: John Baldwin <jhb@FreeBSD.org> [ Data: 2002-09-09 ] > [ Subjecte: RE: cvs commit: src/lib/libc/gen siglist.c ] >> >> On 07-Sep-2002 Juli Mallett wrote: >> > jmallett 2002/09/07 01:14:19 PDT >> > >> > Modified files: >> > lib/libc/gen siglist.c >> > Log: >> > Two arrays were born from the same seeds, both grew into complementary sets >> > of pointers to strings. These two arrays were fixed to the same size, but one >> > had an implicit zeroed trailer element, which was unused because the size was >> > used up by the ones before said zeroed trailer element. So the unused limb was >> > chopped off the over-sized-but-not-over-sized array, and everyone lived happily >> > ever after. >> >> What does this mean in practical terms? > > I removed a comma. Please say so next time. :) Having humor in the occasional log message is perfectly fine. However, a log message still needs to include actual content describing the change and/or the reason for the change. Including a "Seriously, remove extraneous comma" as the final line would still have kept the humor value w/o requiring one to do a cvs diff to see the actual change. Esp. if one happens to find a bug later down the road and is reading log messages in the history to find out where it originated. Having to waste time looking at diff's of obscure messages can be a pain. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020910092242.jhb>