Date: Fri, 24 Sep 2010 19:04:17 +0000 (UTC) From: Pyun YongHyeon <yongari@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/dev/xl if_xl.c Message-ID: <201009241904.o8OJ4Wmg072061@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
yongari 2010-09-24 19:04:17 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_8)
sys/dev/xl if_xl.c
Log:
SVN rev 213117 on 2010-09-24 19:04:17Z by yongari
MFC r211716:
Move xl_reset() to xl_init_locked(). This will make driver
initialize controller from a known good state. Previously driver
used to issue controller reset while TX/RX DMA are in progress.
I guess resetting controller in active TX/RX DMA cycle is to ensure
stopping I/Os in xl_shutdown(). I remember some buggy controllers
didn't respond with stop command if controller is under high
network load at the time of shutdown so resetting controller was
the only safe way to stop the I/Os. However, from my experiments,
controller always responded with stop command under high network
load so I think it's okay to remove the xl_reset() in
device_shutdown handler.
Resetting controller also will clear configured RX filter which
in turn will make WOL support hard because driver have to reprogram
RX filter in WOL handler as well as setting station address.
Revision Changes Path
1.8.2.4 +3 -6 src/sys/dev/xl/if_xl.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009241904.o8OJ4Wmg072061>