Date: Thu, 25 Dec 2014 10:24:51 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276188 - head/sys/netipsec Message-ID: <2AA1B085-9974-4AE5-9498-B07469E5A29B@FreeBSD.org> In-Reply-To: <201412241834.sBOIYvrL078222@svn.freebsd.org> References: <201412241834.sBOIYvrL078222@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24 Dec 2014, at 18:34 , Andrey V. Elsukov <ae@FreeBSD.org> wrote: >=20 > Author: ae > Date: Wed Dec 24 18:34:56 2014 > New Revision: 276188 > URL: https://svnweb.freebsd.org/changeset/base/276188 >=20 > Log: > Rename ip4_def_policy variable to def_policy. It is used by both IPv4 = and > IPv6. Initialize it only once in def_policy_init(). Remove its > initialization from key_init() and make it static. >=20 > Remove several fields from struct secpolicy: > * lock - it isn't so useful having mutex in the structure, but the = only > thing we do with it is initialization and destroying. > * state - it has only two values - DEAD and ALIVE. Instead of take a = lock > and change the state to DEAD, then take lock again in GC function = and > delete policy from the chain - keep in the chain only ALIVE = policies. > * scangen - it was used in GC function to protect from sending = several > SADB_SPDEXPIRE messages for one SPD entry. Now we don't keep DEAD = entries > in the chain and there is no need to have scangen variable. >=20 > Use TAILQ to implement SPD entries chain. Use rmlock to protect = access > to SPD entries chain. Protect all SP lookup with RLOCK, and use WLOCK > when we are inserting (or removing) SP entry in the chain. >=20 > Instead of using pattern "LOCK(); refcnt++; UNLOCK();", use = refcount(9) > API to implement refcounting in SPD. Merge code from key_delsp() and > _key_delsp() into _key_freesp(). And use KEY_FREESP() macro in all = cases > when we want to release reference or just delete SP entry. >=20 > Obtained from: Yandex LLC > Sponsored by: Yandex LLC >=20 > Modified: > head/sys/netipsec/ipsec.c > head/sys/netipsec/ipsec.h > head/sys/netipsec/key.c > head/sys/netipsec/key_debug.c This broke VIMAGE kernel builds. And I=E2=80=99ll repeat what I said before: I appreciate all your work = but at the same time I remain massively worried by major change commits = to security subsystems without any Reviewed by: lines. Please use = appropriate ways to get extra pairs of eyes. Happy holidays! Bjoern =E2=80=94=20 Bjoern A. Zeeb Charles Haddon Spurgeon: "Friendship is one of the sweetest joys of life. Many might have failed beneath the bitterness of their trial had they not found a friend."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2AA1B085-9974-4AE5-9498-B07469E5A29B>