Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Jan 2022 00:27:02 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 620d156421e2 - stable/12 - Build libclang also if LLDB is enabled
Message-ID:  <202201100027.20A0R2TN046186@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=620d156421e249269a4e957a6ad22957308f880f

commit 620d156421e249269a4e957a6ad22957308f880f
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2022-01-07 15:34:08 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2022-01-10 00:25:50 +0000

    Build libclang also if LLDB is enabled
    
    LLDB depends on libclang as it uses Clang as the expression parser.
    Previously setting WITHOUT_CLANG but leaving LLDB enabled (as default)
    resulted in a build failure.
    
    Users who set WITHOUT_CLANG in order to reduce build time or size
    might want to set WITHOUT_LLDB in addition to WITHOUT_CLANG, or use
    WITHOUT_TOOLCHAIN instead.
    
    PR:             260993
    Reported by:    eugen
    Reviewed by:    dim
    MFC after:      3 days
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit adc88b9c01b5d7a51c896091b291afbdae42b02a)
---
 Makefile.inc1      | 3 ++-
 lib/clang/Makefile | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile.inc1 b/Makefile.inc1
index 4852a73756f1..c9777d1d45d3 100644
--- a/Makefile.inc1
+++ b/Makefile.inc1
@@ -2197,7 +2197,8 @@ _localedef=	usr.bin/localedef
 _clang_tblgen= \
 	lib/clang/libllvmminimal \
 	usr.bin/clang/llvm-tblgen
-.if ${MK_CLANG_BOOTSTRAP} != "no" || ${MK_CLANG} != "no"
+.if ${MK_CLANG_BOOTSTRAP} != "no" || ${MK_CLANG} != "no" || \
+    ${MK_LLDB} != "no"
 _clang_tblgen+=	usr.bin/clang/clang-tblgen
 .endif
 .if ${MK_LLDB} != "no"
diff --git a/lib/clang/Makefile b/lib/clang/Makefile
index df4aa01a2653..cbb2c2a7175f 100644
--- a/lib/clang/Makefile
+++ b/lib/clang/Makefile
@@ -4,7 +4,7 @@
 
 # These have to be built in order.
 SUBDIR=		libllvm
-.if ${MK_CLANG} != "no"
+.if ${MK_CLANG} != "no" || ${MK_LLDB} != "no"
 SUBDIR+=	libclang
 SUBDIR+=	headers
 .endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201100027.20A0R2TN046186>