Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 4 Mar 2020 09:41:34 -0500
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Eugene Grosbein <eugen@grosbein.net>, John Baldwin <jhb@FreeBSD.org>, Hiroki Sato <hrs@FreeBSD.org>
Cc:        ume@FreeBSD.org, src-committers@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: [SOLUTION] Re: svn commit: r358411 - head/contrib/sendmail/src
Message-ID:  <0e74f367-a4ff-e678-7c5a-0ca8ea6495ac@FreeBSD.org>
In-Reply-To: <4d974e29-f930-257c-5e0b-7528e745cea4@grosbein.net>
References:  <fdbf3930-c17e-ba4a-4819-e201590b6c9d@FreeBSD.org> <34373b64-876b-c97c-e805-ffaf3a69dd8b@grosbein.net> <8e60a869-fe1e-9314-ffdc-76ed3e2dc081@FreeBSD.org> <20200303.075047.1159550404273266246.hrs@FreeBSD.org> <8c1adcb3-1537-e6ae-e446-f05aee1e3483@grosbein.net> <e764ae2a-23da-2f31-cc6b-1d15639646a1@FreeBSD.org> <9ac02710-8029-18fc-9b2a-383c1a229cdd@grosbein.net> <d6636a65-8793-0676-29a2-14630f2daaaa@FreeBSD.org> <f7559512-1d06-ba7c-7cd7-bd6514e3ae49@grosbein.net> <489d09c9-f0b4-f7b1-6255-51bdeb19b740@FreeBSD.org> <4d974e29-f930-257c-5e0b-7528e745cea4@grosbein.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On 20. 3. 4., Eugene Grosbein wrote:
> 04.03.2020 0:10, John Baldwin wrote:
> 
>> When the handbook text was first written we didn't have an OpenSSL in ports that would conflict
> 
> Thank you very much for this key for solving the problem.
> This occured to be missing bit of information I was looking for.
> 
> So, the fix is simple. We need only two things: first, base sendmail must be linked with base libcrypto
> and second, cyrus-sasl2 must be linked with base libcrypto too,
> despite of presence of openssl from ports, as an option.
> 
> First goal is accomplished by replacing SENDMAIL_LDFLAGS=-L/usr/local/lib
> with SENDMAIL_LDADD=/usr/local/lib/libsasl2.so in /etc/make.conf
> and the Handbook needs this change.
> 
> Second goal is accomplished with r515574 for ports that added new option (disabled by default).
> If enabled, it builds the port using base openssl and libcrypto:
> https://svnweb.freebsd.org/ports?view=revision&revision=515574

The canonical way of overriding ssl version is adding
"DEFAULT_VERSIONS+=ssl=<openssl variant>" to /etc/make.conf.  Please see
ports/Mk/Uses/ssl.mk.  If you want to add a new method to override it
per port, please write a patch for ssl.mk and submit it to portmgr
(maintainer).  There's no reason to hack every single port.

> Unfortunately, it was back out by maintainer (ume) in r527347 as
> "wrong". It was not.
>
> Dear maintainer, please consider applying r515574 back.
> Feel free renaming port option and improving the description, if you
> wish because I cannot think up better version.
>
> New option for cyrus-sasl2 should be mentioned in the Handbook, too.
>
> With these two changes source upgrade path for such stable/11 system
> is unbroken.

I am not the maintainer but why did you do it without maintainer's
approval in the first place? :-(

Jung-uk Kim



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0e74f367-a4ff-e678-7c5a-0ca8ea6495ac>