Date: Sun, 21 Jan 2024 19:47:49 +0100 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: "Mikhail T." <mi+t@virtual-estates.net> Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Message-ID: <d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com> In-Reply-To: <df410abd-dd00-4e7e-83eb-f8a95ec15b9f@virtual-estates.net> References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com> <f74f9837-121e-47ac-819b-27a40d3b4891@virtual-estates.net> <ewlhhqgckfoo4nj2jmryynhh2admdz6wy3lwkyav7nvhok565l@liht5kzkacig> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <ptq5dukjavkfpoe2gic6mssywdxh7f77xsounaxmy5llxinz2j@w6243b7unduq> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <Zaz0W9odSaxyDrCj@fc.opsec.eu> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> <df410abd-dd00-4e7e-83eb-f8a95ec15b9f@virtual-estates.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-01-21T19:27:04.000+01:00, Mikhail T. <mi+t@virtual-estates.net> w= rote: >=C2=A021.01.24=C2=A006:11,=C2=A0Daniel=C2=A0Engberg: >=C2= =A0 >>=C2=A0=C2=A0While=C2=A0neither=C2=A0Porters=C2=A0Handbook=C2=A0or= =C2=A0Committers=C2=A0Guide=C2=A0say=C2=A0it's=C2=A0a >>=C2=A0=C2=A0requi= rement=C2=A0it's=C2=A0quite=C2=A0strongly=C2=A0suggested=C2=A0that=C2=A0you= =C2=A0do=C2=A0use=C2=A0it. >=C2=A0 >=C2=A0Thank=C2=A0you,=C2=A0Daniel,= =C2=A0for=C2=A0confirming,=C2=A0no=C2=A0actual=C2=A0rules=C2=A0were=C2= =A0broken=C2=A0by=C2=A0my >=C2=A0commit. >=C2=A0 >>=C2=A0=C2=A0Given= =C2=A0that=C2=A0all=C2=A0pkg-fallout=C2=A0mails=C2=A0are=C2=A0from=C2=A0Pou= driere=C2=A0it's=C2=A0more=C2=A0or >>=C2=A0=C2=A0less=C2=A0implied=C2= =A0as=C2=A0committer=C2=A0to=C2=A0use=C2=A0it. >=C2=A0 >=C2=A0I=C2= =A0don't=C2=A0see=C2=A0the=C2=A0implication=C2=A0at=C2=A0all.=C2=A0I=C2= =A0appreciate=C2=A0the=C2=A0fallout >=C2=A0e-mails,=C2=A0but=C2=A0I=C2= =A0don't=C2=A0see,=C2=A0why=C2=A0that=C2=A0makes=C2=A0it=C2=A0mandatory= =C2=A0for=C2=A0me=C2=A0to=C2=A0use >=C2=A0the=C2=A0same=C2=A0tool(s)= =C2=A0locally.=C2=A0For=C2=A0example,=C2=A0the=C2=A0cluster=C2=A0builds= =C2=A0every=C2=A0port >=C2=A0on=C2=A0multiple=C2=A0hardware=C2=A0platform= s=C2=A0--=C2=A0for=C2=A0different=C2=A0OS-releases.=C2=A0Does >=C2=A0that= =C2=A0imply=C2=A0the=C2=A0committers=C2=A0also=C2=A0must=C2=A0have=C2=A0suc= h=C2=A0multitude=C2=A0of=C2=A0different >=C2=A0hardware/release=C2=A0comb= inations=C2=A0locally=C2=A0too? >=C2=A0 >=C2=A0I=C2=A0still=C2=A0don't= =C2=A0understand,=C2=A0why=C2=A0you=C2=A0asked=C2=A0me=C2=A0to=C2=A0backout= ...=C2=A0Mat's >=C2=A0attempt=C2=A0at=C2=A0answering=C2=A0amounted=C2= =A0to:=C2=A0"Because=C2=A0you=C2=A0broke=C2=A0the=C2=A0rules!"=C2=A0-- >= =C2=A0which=C2=A0is=C2=A0not=C2=A0a=C2=A0valid=C2=A0reason=C2=A0even=C2= =A0if=C2=A0any=C2=A0rules=C2=A0really=C2=A0were=C2=A0broken. >=C2=A0Clear= ly=C2=A0a=C2=A0personal=C2=A0thing...=C2=A0 >=C2=A0 >=C2=A0If=C2=A0the= =C2=A037=C2=A0seconds=C2=A0it=C2=A0took=C2=A0the=C2=A0cluster=C2=A0to=C2= =A0fail=C2=A0the=C2=A0port=C2=A0is=C2=A0really >=C2=A0such=C2=A0a=C2= =A0drain=C2=A0on=C2=A0the=C2=A0resources,=C2=A0marking=C2=A0the=C2=A0port= =C2=A0BROKEN=C2=A0would=C2=A0be=C2=A0a >=C2=A0thing=C2=A0to=C2=A0do=C2= =A0--=C2=A0that's=C2=A0a=C2=A0one-line=C2=A0change,=C2=A0that=C2=A0still= =C2=A0keeps=C2=A0the=C2=A0code >=C2=A0available=C2=A0for=C2=A0sharing. = >=C2=A0 >=C2=A0Anyway,=C2=A0I=C2=A0think,=C2=A0I=C2=A0hacked=C2=A0the= =C2=A0port=C2=A0into=C2=A0pre-fetching=C2=A0the=C2=A0additional >=C2= =A0modules=C2=A0using=C2=A0go.mk=C2=A0[http://go.mk]'s=C2=A0facilities,= =C2=A0and=C2=A0will=C2=A0be >=C2=A0committing=C2=A0that=C2=A0shortly.= =C2=A0It=C2=A0still=C2=A0is=C2=A0not=C2=A0perfect,=C2=A0because=C2=A0the= =C2=A0port >=C2=A0is=C2=A0a=C2=A0mixture=C2=A0of=C2=A0C=C2=A0and=C2=A0Go-= code,=C2=A0but=C2=A0it=C2=A0should=C2=A0build=C2=A0fine=C2=A0now.=C2=A0Than= k >=C2=A0you=C2=A0for=C2=A0the=C2=A0feedback.=C2=A0Yours, >=C2=A0 >>= =C2=A0=C2=A0-mi Hi, While we all do mistakes I'm asking because i= t's broken and it's likely not going to be fixed any time soon. In realit= y it adds noise (which we already have enough of) on lists, Poudriere bui= lds (because by default we build all ports) takes more time producing not= hing, more time for people to review error logs and so on. It boils down = to my time > your time which usually don't translate well in team efforts= . Instead of doing the same thing again use Poudriere as you're by kno= w well aware that it "should" be used and you have been "warned". I wou= ld also say that you'd be better off in general asking for suggestions by= creating a PR and or use Phab(ricator) due to quality reasons (to mentio= n it again, team effort). Best regards, Daniel --_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <div>On 2024-01-21T19:27:04.000+01:00, Mikhail T. <mi+t@virtual-estates.= net> wrote:<br></div><div class=3D"ik_mail_quote answerContentMessage"><= blockquote class=3D"ws-ng-quote"><div class=3D"ws-ng-mail-style--12522eJzzz= EvKr9B1K0pNdQp20QILyop1k3Oz83NLCkGAIbYCfk"><div class=3D"">21.01.24 06:11, = Daniel Engberg:<br></div><blockquote type=3D"cite">While neither Porters Handbook or Committers Guide say it's a requirement it's quite strongly suggested that you do use it.<br></bl= ockquote><p><br></p><p>Thank you, Daniel, for confirming, no actual rules w= ere broken by my commit.<br></p><blockquote type=3D"cite">Given that all pkg-fallout mails are from Poudriere it's more or less implied as committer to use it.<br></blockquote><p>I don't see the im= plication at all. I appreciate the fallout e-mails, but I don't see, why that makes it mandatory for me to use the same tool(s) locally. For example, the cluster builds every port on multiple hardware platforms -- for different OS-releases. Does that imply the committers also must have such multitude of different hardware/release combinations locally too?<br>= </p><p>I still don't understand, why you asked me to backout... Mat's attempt at answering amounted to: "Because you broke the rules!" -- which is not a valid reason even if any rules really were broken. Clearly a personal thing... <br></p><p>If the 37 seconds it t= ook the cluster to fail the port is really such a drain on the resources, marking the port BROKEN would be a thing to do -- that's a one-line change, that still keeps the code available for sharing.<br></p><p>Anyway, I think, I hacked the port i= nto pre-fetching the additional modules using <span class=3D"font" style=3D"font-family:mo= nospace"><a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" href=3D"http:= //go.mk" class=3D"defaultMailLink defaultMailLink" target=3D"_blank">go.mk<= /a></span>'s facilities, and will be committing that shortly. It still is not perfect, because the port is a mixture of C and Go-code, but it should build fine now. Thank you for the feedback. Yours,<br></p><div= class=3D"ik-toggle-quote-button"><br></div><blockquote><p>-mi<br></p></blo= ckquote></div></blockquote></div><div>Hi,<br></div><div><br></div><div>Whil= e we all do mistakes I'm asking because it's broken and it's likely not goi= ng to be fixed any time soon. In reality it adds noise (which we already ha= ve enough of) on lists, Poudriere builds (because by default we build all p= orts) takes more time producing nothing, more time for people to review err= or logs and so on. It boils down to my time > your time which usually do= n't translate well in team efforts.<br></div><div><br></div><div>Instead of= doing the same thing again use Poudriere as you're by know well aware that= it "should" be used and you have been "warned". I would also say that you'= d be better off in general asking for suggestions by creating a PR and or u= se Phab(ricator) due to quality reasons (to mention it again, team effort).= <br></div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div> --_=_swift_1705862869_4a527cceade8370beb9467ac1a18eb1e_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d745fc126e79b4455dfc3e87964baa54>