Date: Thu, 09 Apr 2026 02:41:23 +0000 From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 84ce651836e0 - main - <sys/extattr.h>: use designated initializers for EXTATTR_NAMESPACE_NAMES Message-ID: <69d711d3.42940.7e1164c8@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=84ce651836e0d037f611cd33a5c65e1d57049432 commit 84ce651836e0d037f611cd33a5c65e1d57049432 Author: Kyle Evans <kevans@FreeBSD.org> AuthorDate: 2026-04-09 02:41:12 +0000 Commit: Kyle Evans <kevans@FreeBSD.org> CommitDate: 2026-04-09 02:41:12 +0000 <sys/extattr.h>: use designated initializers for EXTATTR_NAMESPACE_NAMES This is not a functional change, but it makes it more clear upon inspection of the definition that the mapping property described is preserved. Maybe more importantly, if one ends up getting an index wrong or punching a hole in the name array unexpectedly, then it'll hopefully manifest more clearly as a (null) or nullptr deref rather than potentially just emitting the wrong namespace name. It's noted that this almost certainly invalidates its use in C++, but there aren't really any known C++ consumers of it- let's just cross that bridge if we get there. Reviewed by: kib, mckusick, rmacklem Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D55323 --- sys/sys/extattr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/sys/extattr.h b/sys/sys/extattr.h index 4aabb4af667b..91bc5210a541 100644 --- a/sys/sys/extattr.h +++ b/sys/sys/extattr.h @@ -53,9 +53,9 @@ * char *extattr_namespace_names[] = EXTATTR_NAMESPACE_NAMES; */ #define EXTATTR_NAMESPACE_NAMES { \ - EXTATTR_NAMESPACE_EMPTY_STRING, \ - EXTATTR_NAMESPACE_USER_STRING, \ - EXTATTR_NAMESPACE_SYSTEM_STRING } + [EXTATTR_NAMESPACE_EMPTY] = EXTATTR_NAMESPACE_EMPTY_STRING, \ + [EXTATTR_NAMESPACE_USER] = EXTATTR_NAMESPACE_USER_STRING, \ + [EXTATTR_NAMESPACE_SYSTEM] = EXTATTR_NAMESPACE_SYSTEM_STRING } #define EXTATTR_MAXNAMELEN NAME_MAXhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69d711d3.42940.7e1164c8>