Date: Tue, 4 Sep 2001 21:12:23 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/stdlib strtol.c strtoll.c strtoq.c strtoul.c strtoull.c strtouq.c Message-ID: <20010904211223.G17754@sunbay.com> In-Reply-To: <20010904215042.B33069@nagual.pp.ru>; from ache@nagual.pp.ru on Tue, Sep 04, 2001 at 09:50:43PM %2B0400 References: <200109041741.f84HfKt00857@freefall.freebsd.org> <20010904204820.E17754@sunbay.com> <20010904215042.B33069@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 04, 2001 at 09:50:43PM +0400, Andrey A. Chernov wrote: > On Tue, Sep 04, 2001 at 20:48:20 +0300, Ruslan Ermilov wrote: > > This is bogus. Please do it the style(9) way. > > What do you mean exactly? Most of our libc files not have rcsids - they > are just space waste. > Just look at the -CURRENT style(9) manual: : After any copyright header, there is a blank line, and the rcsid for : source files. Version control system ID tags should only exist once in a : file (unlike this one). Non-C/C++ source files follow the above example, : while C/C++ source files follow the below one. All VCS (version control ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ : system) revision identification from files obtained from elsewhere should : be maintained, including if there are multiple IDs showing a file's his- : tory. In general, keep the IDs in tact, including any `$'s. Most : non-FreeBSD VCS IDs should be indented by a tab if in a comment. : : #ifndef lint : #if 0 : static char sccsid[] = "@(#)style 1.14 (Berkeley) 4/28/95"; : #endif : static const char rcsid[] = : "$FreeBSD: src/share/man/man9/style.9,v 1.32.2.14 2001/08/17 13:08:54 ru Exp $"; : #endif /* not lint */ strtoull.c used to be valid before your change. This might seem to be slightly different from what in style, but actually it isn't, because LIBC_SCCS is not defined. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010904211223.G17754>