Date: Wed, 6 Sep 1995 22:17:09 +1000 From: Bruce Evans <bde@zeta.org.au> To: bde@zeta.org.au, wollman@lcs.mit.edu Cc: CVS-commiters@freefall.FreeBSD.org, bde@freefall.FreeBSD.org, cvs-sys@freefall.FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_map.h vm_map.c Message-ID: <199509061217.WAA20880@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>> 2) for protoswitch functions. The number and type of args sometimes >> depends on the protocol. >For pr_input routines, it always depends on the protocol. The >solution that I prefer for these is to declare pr_input as a `void >(*)(void)' and then define some protocol-specific macros to cast it to >the correct value. If there were a way I could think of to use unions >the same way for increased type-safety, I'd prefer that. I'm still thinking about this. I've found so many gratuitous function type mismatches in places where prototypes were supposedly being used that I disklike casts even more than before. What about the pr_output routines? pr_output seems to be called only once, in raw_usrreq.c, and one callee, ip_output, seems to be completely unprepared for the call. This is detected as a bogus initialization in inetsw in in_proto.c. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199509061217.WAA20880>