Date: Sat, 21 Jan 2006 14:05:06 +0000 (GMT) From: Robert Watson <rwatson@FreeBSD.org> To: Stefan Farfeleder <stefanf@FreeBSD.org> Cc: Tom Rhodes <trhodes@FreeBSD.org>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsserver nfs_serv.c Message-ID: <20060121140330.S93517@fledge.watson.org> In-Reply-To: <20060121134636.GC611@wombat.fafoe.narf.at> References: <200601211210.k0LCAXYl069896@repoman.freebsd.org> <20060121134636.GC611@wombat.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Jan 2006, Stefan Farfeleder wrote: > On Sat, Jan 21, 2006 at 12:10:33PM +0000, Tom Rhodes wrote: >> trhodes 2006-01-21 12:10:33 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/nfsserver nfs_serv.c >> Log: >> Remove some dead code. >> >> Found with: Coverity Prevent(tm) > > Hm, are you sure this change is correct? Apparently Coverity thinks that > dirp is always 0 at this point, yes? Looking at nfs_namei() I don't believe > that. Also the comment above this is now stale and the code inside 'if > (error)' not indented properly. I was purposefully avoiding trying to investigate the NFS reports from Coverity as the NFS macro maze is very twisty, and the dead code reports are more likely logical errors preventing reaching code that shouldn't be dead than code that is actually no longer useful. I figured I would leave them for a quiet long weekend. Given the above, I suspect strongly my instinct was right. :-) Robert N M Watson
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060121140330.S93517>