Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Oct 2008 11:36:55 GMT
From:      Peter Wemm <peter@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 152094 for review
Message-ID:  <200810281136.m9SBatKU098151@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=152094

Change 152094 by peter@peter_overcee on 2008/10/28 11:36:10

	Fix (?) mmap offset truncation.

Affected files ...

.. //depot/projects/valgrind/coregrind/m_aspacemgr/aspacemgr-common.c#3 edit

Differences ...

==== //depot/projects/valgrind/coregrind/m_aspacemgr/aspacemgr-common.c#3 (text+ko) ====

@@ -159,11 +159,14 @@
         || defined(VGP_ppc32_aix5) || defined(VGP_ppc64_aix5)
    res = VG_(do_syscall6)(__NR_mmap, (UWord)start, length, 
                          prot, flags, fd, offset);
-#  elif defined(VGO_freebsd)
+#  elif defined(VGP_x86_freebsd)
+   if (flags & VKI_MAP_ANONYMOUS && fd == 0)
+      fd = -1;
+   res = VG_(do_syscall8)(__NR_mmap, (UWord)start, length,
+			  prot, flags, fd, 0, offset, offset >> 32ul);
+#  elif defined(VGP_amd64_freebsd)
    if (flags & VKI_MAP_ANONYMOUS && fd == 0)
       fd = -1;
-   // AAA: fix 64 bit start
-   // QQQ: truncates to 32 bit offset!!
    res = VG_(do_syscall7)(__NR_mmap, (UWord)start, length,
 			  prot, flags, fd, 0, offset);
 #  else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810281136.m9SBatKU098151>