Date: Sat, 20 Oct 2018 14:04:29 -0700 From: Conrad Meyer <cem@freebsd.org> To: Ed Schouten <ed@nuxi.nl> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339468 - in head/sys: kern sys Message-ID: <CAG6CVpWE_Y=FCz8qYKL2Mtre1coxYsL-iyiy_6_RRvgrJ2ppvw@mail.gmail.com> In-Reply-To: <CABh_MKn3cyaWRcBC0NWQMK3K7od2OHj0jcuiChXySMc_7=1wzw@mail.gmail.com> References: <201810201831.w9KIVbtN043921@repo.freebsd.org> <CABh_MKmTKqCcPbfrA_9HY71GN0heKqSXh-s4ttXemjPK4GCb3Q@mail.gmail.com> <CAG6CVpUdQUYdj2jCmjV_cVmZNm%2B2=%2BapzE0u_xDkND=LTV8Vjw@mail.gmail.com> <CABh_MKn3cyaWRcBC0NWQMK3K7od2OHj0jcuiChXySMc_7=1wzw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Yep! On Sat, Oct 20, 2018 at 1:49 PM Ed Schouten <ed@nuxi.nl> wrote: > > Op za 20 okt. 2018 om 21:59 schreef Conrad Meyer <cem@freebsd.org>: > > > Can kdb_active, tp == NULL and panicstr != NULL even occur in this > > > case? tty_info() can only get called in non-degenerate cases, right? > > > > I think you are correct, but I did not want to investigate to confirm. > > This was just the direct, conservative conversion of ttyprintf -> > > putchar. The checks can *probably* be removed. > > If they can, then certain other parts of this change can be reverted > as well (e.g., the addition of cnputsn). > > -- > Ed Schouten <ed@nuxi.nl>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWE_Y=FCz8qYKL2Mtre1coxYsL-iyiy_6_RRvgrJ2ppvw>