Date: Sun, 21 Jan 2024 14:16:19 -0500 From: "Mikhail T." <mi+t@virtual-estates.net> To: Daniel Engberg <daniel.engberg.lists@pyret.net> Cc: Kurt Jaeger <pi@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b430a140c818 - main - net-im/purple-gowhatsapp: add WhatsApp plugin for libpurple Message-ID: <7ae9295a-0b05-4589-85d9-440ba373707f@virtual-estates.net> In-Reply-To: <d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com> References: <202401202030.40KKUApC045320@gitrepo.freebsd.org> <f22ba5fb94cbee57ef6dbac2bdb3db87@mail.infomaniak.com> <f74f9837-121e-47ac-819b-27a40d3b4891@virtual-estates.net> <ewlhhqgckfoo4nj2jmryynhh2admdz6wy3lwkyav7nvhok565l@liht5kzkacig> <7e07375b-32bc-4778-8977-d87d6e135679@virtual-estates.net> <ptq5dukjavkfpoe2gic6mssywdxh7f77xsounaxmy5llxinz2j@w6243b7unduq> <8ab62f5f-bb62-4633-9d1c-d7a8a8e1fc8a@virtual-estates.net> <Zaz0W9odSaxyDrCj@fc.opsec.eu> <13433172-a8cb-494c-a435-fd4d8418a2e6@virtual-estates.net> <21dcca053d36f9bec4005ffb18897f51@mail.infomaniak.com> <df410abd-dd00-4e7e-83eb-f8a95ec15b9f@virtual-estates.net> <d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------76HxRvGC7aDpBCiWsCdMRUXN
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
21.01.24 13:47, Daniel Engberg:
> While we all do mistakes I'm asking because it's broken and it's
> likely not going to be fixed any time soon.
I wonder, how you estimate this likelihood...
> In reality it adds noise (which we already have enough of) on lists,
> Poudriere builds (because by default we build all ports) takes more
> time producing nothing, more time for people to review error logs and
> so on.
All of this could be silenced with BROKEN, no?
> It boils down to my time > your time which usually don't translate
> well in team efforts.
No, I don't see it boiling down to that. To me it seems like a simple
overreaction. So, a newly-added port is broken -- what's the big deal?
You'd be right expecting the committer to examine the error-log
himself... It is just computers working -- so the humans, present
company included, can do fun things.
> Instead of doing the same thing again use Poudriere as you're by know
> well aware that it "should" be used and you have been "warned".
On the contrary -- as long as the "should" remains quoted, I intend to
do the same thing: /commit, what I sincerely believe is working code/.
Mat is already convinced, I *must* follow, what you acknowledge is just
a recommendation -- on the strength of his creating a rule out of void.
Rights not exercised are rights lost, and all that :-)
> I would also say that you'd be better off in general asking for
> suggestions by creating a PR and or use Phab(ricator) due to quality
> reasons (to mention it again, team effort).
Believe it or not, I did ask for suggestions before committing --
sending the shar of the would be port to the committers of <go.mk>
(because go@FreeBSD.mk is blocked to non-subscribers). Having received
no immediate replies, I figured, I'll see, what Poudriere would say --
still don't understand the scale of the blowback...
-mi
--------------76HxRvGC7aDpBCiWsCdMRUXN
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">21.01.24 13:47, Daniel Engberg:<br>
</div>
<blockquote type="cite"
cite="mid:d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com">
<div>While we all do mistakes I'm asking because it's broken and
it's likely not going to be fixed any time soon.</div>
</blockquote>
I wonder, how you estimate this likelihood...<br>
<blockquote type="cite"
cite="mid:d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com">
<div>In reality it adds noise (which we already have enough of) on
lists, Poudriere builds (because by default we build all ports)
takes more time producing nothing, more time for people to
review error logs and so on.</div>
</blockquote>
All of this could be silenced with BROKEN, no?
<blockquote type="cite"
cite="mid:d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com">
<div>It boils down to my time > your time which usually don't
translate well in team efforts.<br>
</div>
</blockquote>
<p>No, I don't see it boiling down to that. To me it seems like a
simple overreaction. So, a newly-added port is broken -- what's
the big deal? You'd be right expecting the committer to examine
the error-log himself... It is just computers working -- so the
humans, present company included, can do fun things.</p>
<blockquote type="cite"
cite="mid:d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com">
<div>Instead of doing the same thing again use Poudriere as you're
by know well aware that it "should" be used and you have been
"warned".</div>
</blockquote>
On the contrary -- as long as the "should" remains quoted, I intend
to do the same thing: <i>commit, what I sincerely believe is
working code</i>. Mat is already convinced, I <b>must</b> follow,
what you acknowledge is just a recommendation -- on the strength of
his creating a rule out of void. Rights not exercised are rights
lost, and all that :-)<br>
<blockquote type="cite"
cite="mid:d745fc126e79b4455dfc3e87964baa54@mail.infomaniak.com">
<div>I would also say that you'd be better off in general asking
for suggestions by creating a PR and or use Phab(ricator) due to
quality reasons (to mention it again, team effort).</div>
</blockquote>
<p>Believe it or not, I did ask for suggestions before committing --
sending the shar of the would be port to the committers of
<go.mk> (because <a class="moz-txt-link-abbreviated" href="mailto:go@FreeBSD.mk">go@FreeBSD.mk</a> is blocked to
non-subscribers). Having received no immediate replies, I figured,
I'll see, what Poudriere would say -- still don't understand the
scale of the blowback...<br>
</p>
<blockquote>
<p>-mi<br>
</p>
</blockquote>
</body>
</html>
--------------76HxRvGC7aDpBCiWsCdMRUXN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7ae9295a-0b05-4589-85d9-440ba373707f>