Date: Mon, 13 Nov 1995 18:23:12 +0300 (MSK) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (aka Andrey A. Chernov, Black Mage) <ache@astral.msk.su> To: davidg@Root.COM Cc: CVS-commiters@freefall.FreeBSD.ORG, Peter Wemm <peter@jhome.dialix.com>, security@freebsd.org Subject: Re: cvs commit: CVSROOT log_accum.pl Message-ID: <wwWBsfmucE@ache.dialup.demos.ru> In-Reply-To: <199511121803.KAA02195@corbin.Root.COM>; from David Greenman at Sun, 12 Nov 1995 10:03:10 -0800 References: <199511121803.KAA02195@corbin.Root.COM>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199511121803.KAA02195@corbin.Root.COM> David Greenman
writes:
>>In message <Pine.BSF.3.91.951103212121.283A-100000@jhome.DIALix.COM>
>> Peter Wemm writes:
>>
>>>I'm running a variant of what you proposed in my kernel at the moment..
>>> if (!SESS_LEADER(p))
>>> printf("setlogin called from a non session leader, pid %d\n", p->p_pid);
>>
>>>I do not doubt that your fix is a "good thing" and will be required sooner
>>>or later, I just want to make sure we are not going to to have a hundred
>>>bug reports "xdm doesn't work any more" or some other program that we're
>>>not aware of yet.
>>
>>Peter, do you have any progress in this issue for now?
>>Maybe it is time to commit my fix to -current?
> If we decide to change setlogin() so that it only works for session
>leaders, then I'd prefer that we leave out the printf(). If you want to add
>that to your own sources, fine, but I prefer to keep console noise minimized
>to important failures.
Of course. Printf introduced by Peter, I mean "return (EPERM);" here
not a printf. I refer on my original fix and not to quoted variant
from Peter. Setlogin must affect only _current_ session as clearly
said in manpage (and from common sense), so no doubts here.
--
Andrey A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
http://dt.demos.su/~ache : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?wwWBsfmucE>