Date: Wed, 6 Sep 2023 18:46:59 -0700 From: Colin Percival <cperciva@freebsd.org> To: Zhenlei Huang <zlei@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 1926d5cef6ea - main - init_main: Record completed SYSINITs Message-ID: <dc68e74c-43ff-31ad-42f8-6790eddc0301@freebsd.org> In-Reply-To: <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org> References: <202309061837.386Ib5AK086264@gitrepo.freebsd.org> <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/6/23 18:12, Zhenlei Huang wrote: >> On Sep 7, 2023, at 2:37 AM, Colin Percival <cperciva@FreeBSD.org> wrote: >> init_main: Record completed SYSINITs >> >> When removing them from sysinit_list, append them to sysinit_done_list; >> print this list from 'show sysinit' along with the list of future >> sysinits. > > So the `sysinit_done_list` is for DDB only. Well... sort of. You can open up kgdb and run 'p sysinit_done_list'. >> static STAILQ_HEAD(sysinitlist, sysinit) sysinit_list; >> +static struct sysinitlist sysinit_done_list = >> + STAILQ_HEAD_INITIALIZER(sysinit_done_list); > > Then it should be wrapped around with #ifdef DDB and #endif I considered that, but since we're literally talking about 2 pointers of memory I figured it wasn't worth making it conditional. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?dc68e74c-43ff-31ad-42f8-6790eddc0301>