Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 May 2026 12:39:35 +0000
From:      Olivier Certner <olce@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: a652d9763059 - main - acpi_spmc(4): Fix comments on constraints storage
Message-ID:  <6a047107.19dae.672f43a2@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by olce:

URL: https://cgit.FreeBSD.org/src/commit/?id=a652d97630599c089a722d4cb881e2731c5336a8

commit a652d97630599c089a722d4cb881e2731c5336a8
Author:     Olivier Certner <olce@FreeBSD.org>
AuthorDate: 2026-05-04 11:38:58 +0000
Commit:     Olivier Certner <olce@FreeBSD.org>
CommitDate: 2026-05-13 12:38:13 +0000

    acpi_spmc(4): Fix comments on constraints storage
    
    The fields themselves are not unused, we actually fill them, but once
    filled we indeed do not use their values (yet).  See the '#ifdef notyet'
    section in acpi_spmc_check_constraints().
    
    No functional change.
    
    Reviewed by:    emaste, obiwac, imp
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D56798
---
 sys/dev/acpica/acpi_spmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sys/dev/acpica/acpi_spmc.c b/sys/dev/acpica/acpi_spmc.c
index 03944800327d..d8fa5617c8bf 100644
--- a/sys/dev/acpica/acpi_spmc.c
+++ b/sys/dev/acpica/acpi_spmc.c
@@ -150,11 +150,11 @@ struct acpi_spmc_constraint {
 	int		min_d_state;
 	ACPI_HANDLE	handle;
 
-	/* Unused, spec only. */
+	/* Intel only.  Currently filled but unused. */
 	uint64_t	lpi_uid;
 	uint64_t	min_dev_specific_state;
 
-	/* Unused, AMD only. */
+	/* AMD only.  Currently filled but unused. */
 	uint64_t	function_states;
 };
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a047107.19dae.672f43a2>