Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 04 Jun 2000 23:36:47 +0900
From:      "Daniel C. Sobral" <dcs@newsguy.com>
To:        "Andrey A. Chernov" <ache@FreeBSD.ORG>
Cc:        Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>, freebsd-hackers@FreeBSD.ORG, Peter Wemm <peter@FreeBSD.ORG>, Wei Dai <weidai@eskimo.com>
Subject:   Re: -STABLE (was: ncurses.h and #define trace _nc_trace)
Message-ID:  <393A697F.BA97DE3@newsguy.com>
References:  <20000526073056.A12504@freebsd.org> <Pine.BSF.4.21.0006031840080.77834-100000@deneb.dbai.tuwien.ac.at> <20000603121011.A91492@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
"Andrey A. Chernov" wrote:
> 
> > However you do it, please fix this ASAP, and be it by reverting the
> > original, broken patch!
> 
> I wish but I can't.  If I'll touch those misterious CVS branches structure
> again, everyone shoot at me as in previous time.  I think it is enough for
> me.  Nowdays some mystic with CVS branches values much more than fixes.  :-(

You revert to the original by applying the reverse patch of your changes
and committing that. This can be easily done with cvs. And then you
explain in the commit messages why it was reverted. This way, what you
intended to do stays in the log, and why it had to be backed out stays
in the log, so people won't blunder into doing the same thing again in
the future.

Well, not anyone who has the wisdom of checking the cvs log for similar
changes in the past first, which ought to be a standard practice for
committers.

-- 
Daniel C. Sobral			(8-DCS)

dcs@newsguy.com
dcs@freebsd.org
capo@yet.another.bsdconspiracy.org

	Hmmm - I have to go check this. My reality assumptions are shattered.




To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?393A697F.BA97DE3>