Date: Tue, 7 Nov 2017 21:06:11 -0500 From: Mark Johnston <markj@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325528 - head/sys/vm Message-ID: <20171108020611.GA62104@raichu> In-Reply-To: <201711080153.vA81r3Sd092898@repo.freebsd.org> References: <201711080153.vA81r3Sd092898@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 08, 2017 at 01:53:03AM +0000, Mark Johnston wrote: > Author: markj > Date: Wed Nov 8 01:53:03 2017 > New Revision: 325528 > URL: https://svnweb.freebsd.org/changeset/base/325528 > > Log: > Correct the type of foff. > > No functional change intended. Sorry for not clarifying the second sentence. vm_offset_t is 32 bits wide on some architectures, while vm_ooffset_t is always 64 bits wide. However, foff is only used when allocating a vnode pager with vm_pager_allocate(), and vnode_pager_alloc()'s "offset" parameter is unused. So the bug was real, but had no effect.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171108020611.GA62104>