Date: Tue, 21 May 2002 16:04:51 +0100 From: Brian Somers <brian@Awfulhak.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Brian Somers <brian@Awfulhak.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Makoto Matsushita <matusita@jp.FreeBSD.org> Subject: Re: cvs commit: src/sys/i386/i386 userconfig.c Message-ID: <200205211504.g4LF4plr006616@hak.lan.Awfulhak.org> In-Reply-To: Message from John Baldwin <jhb@FreeBSD.org> of "Tue, 21 May 2002 10:38:48 EDT." <XFMail.20020521103848.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 21-May-2002 Brian Somers wrote:
> >>
> >> jhb> Compile in the 'intro' command if VISUAL_USERCONFIG is
> >> jhb> specified not just for INTRO_USERCONFIG. This allows a
> >> jhb> userconfig script to use the 'intro' command to bring up the
> >> jhb> introduction kernel config screen which cdboot ISO's use.
> >>
> >> Wonderful!
> >>
> >> jhb> The only downside for a cdboot ISO now is that when you boot up
> >> jhb> you get bogus error messages from kldloading the drivers in the
> >> jhb> mfsroot since the kernel modules are already present in GENERIC.
> >>
> >> I'm also same problem in my mind. Perhaps we can steal some codes
> >> (or logics) from ifmaybeload() at src/usr.sbin/ifconfig/ifconfig.c.
> >
> > Or perhaps src/usr.sbin/ppp/defs.c:loadmodules().
>
> Maybe we need a generic function in libutil then to avoid duplicating
> this code.
The problem is that the code would read something like:
int
loadmodule(const char *module)
{
if (modfind(module) == -1)
return (kldload(module));
return (0);
}
A bit unnecessary really....
(I put loadmodules() into ppp because I tend to need to load more than
one module, and it was more convenient that way....).
> --
>
> John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/
> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
--
Brian <brian@Awfulhak.org> <brian@freebsd-services.com>
<http://www.Awfulhak.org>; <brian@[uk.]FreeBSD.org>
Don't _EVER_ lose your sense of humour ! <brian@[uk.]OpenBSD.org>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205211504.g4LF4plr006616>