Date: Thu, 13 Jul 2017 19:33:14 -0700 From: Ryan Libby <rlibby@gmail.com> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: Ryan Libby <rlibby@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Eric Joyner <erj@freebsd.org> Subject: Re: svn commit: r320977 - head/sys/dev/ixl Message-ID: <CAHgpiFwD-opucqnfByBErhUswRDnx1Yoj0eODR7rGOzUfZHiQg@mail.gmail.com> In-Reply-To: <CAGHfRMAZBRqmk=xL_01F_Mkm2wgvjw2nYHv2vpKHVH07Q1FU5w@mail.gmail.com> References: <201707140010.v6E0ApLQ052889@repo.freebsd.org> <CAGHfRMAZBRqmk=xL_01F_Mkm2wgvjw2nYHv2vpKHVH07Q1FU5w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 13, 2017 at 6:17 PM, Ngie Cooper <yaneurabeya@gmail.com> wrote: > On Thu, Jul 13, 2017 at 5:10 PM, Ryan Libby <rlibby@freebsd.org> wrote: >> Author: rlibby >> Date: Fri Jul 14 00:10:51 2017 >> New Revision: 320977 >> URL: https://svnweb.freebsd.org/changeset/base/320977 > > ... > >> +const char * const ixl_fc_string[6] = { >> + "None", >> + "Rx", >> + "Tx", >> + "Full", >> + "Priority", >> + "Default" >> +}; > > This should use flexible arrays, e.g., > > const char * const ixl_fc_string[] = { > "None", > ... > }; > > -Ngie Since this is status quo and a style point, I think I will leave this to erj's judgement. Ryan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHgpiFwD-opucqnfByBErhUswRDnx1Yoj0eODR7rGOzUfZHiQg>