Date: Sun, 8 Nov 2009 17:20:06 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Alexander Motin <mav@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r199050 - in head/sys: conf dev/ata Message-ID: <20091108152006.GS2331@deviant.kiev.zoral.com.ua> In-Reply-To: <4AF6D85B.4040905@FreeBSD.org> References: <200911081433.nA8EXJnp088767@svn.freebsd.org> <20091108143633.GR2331@deviant.kiev.zoral.com.ua> <4AF6D85B.4040905@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--B9I4cJCE9PLEoxgz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 08, 2009 at 04:40:27PM +0200, Alexander Motin wrote: > Kostik Belousov wrote: > > On Sun, Nov 08, 2009 at 02:33:19PM +0000, Alexander Motin wrote: > >> Author: mav > >> Date: Sun Nov 8 14:33:19 2009 > >> New Revision: 199050 > >> URL: http://svn.freebsd.org/changeset/base/199050 > >> > >> Log: > >> Introduce define and kernel option ATA_REQUEST_TIMEOUT to control AT= A(4) > >> command timeout. > >=20 > > Why is this a compile-time option ? Having to recompile kernel for this > > is too much, IMHO. It should be loader tunable + sysctl, isn't it. >=20 > As I have told once, I think it is not a thing that should be often > tuned by end-user, especially in real-time. I just turned it into macro, Absolutely. I agree with that most users never need this tunable. > as some people complain about using numerous equal numeric constants. But, why not be somewhat more friendly to a user that already has a problam, and force him to recompile the kernel only to check whether it helps or not ? --B9I4cJCE9PLEoxgz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkr24aYACgkQC3+MBN1Mb4gMvwCeNjHRt94gy9wvCQTrLeyecrCi ueQAn212MIZ6f44YXQ0gmZwZZatLe3NI =M6r1 -----END PGP SIGNATURE----- --B9I4cJCE9PLEoxgz--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091108152006.GS2331>