Date: Sun, 12 Jun 2022 11:18:21 -0400 From: Matteo Riondato <matteo@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: nvme INVALID_FIELD in dmesg.boot Message-ID: <20220612151821.3a2fkfsqlr7ro7gf@ubertino.local> In-Reply-To: <CANCZdfqf%2Bqy6%2B9wWu65g4JRtTc6Gx4wJFhAq%2BN91o--Zqoziow@mail.gmail.com> References: <20220525122529.t2kwfg2q65dfiyyt@host-ubertino-mac-88e9fe7361f5.eduroam.ssid.10net.amherst.edu> <d8462935-2874-2e5c-a7aa-d5352bd0a3c2@FreeBSD.org> <20220526001715.4ffee96a@ws1.wobblyboot.net> <CANCZdfrYP-Wz7a-%2B_WEKbT=Yb=mrk0YYifDkzekV6H2q865sDg@mail.gmail.com> <20220525153920.sxzi7fhsfzv6yidv@ubertino.local> <CANCZdfqf%2Bqy6%2B9wWu65g4JRtTc6Gx4wJFhAq%2BN91o--Zqoziow@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--n3rvye4kcg25rgka Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2022-05-25 at 11:49 EDT, Warner Losh <imp@bsdimp.com> wrote: >On Wed, May 25, 2022 at 9:39 AM Matteo Riondato <matteo@freebsd.org> wrote: > >> On 2022-05-25 at 11:29 EDT, Warner Losh <imp@bsdimp.com> wrote:=20 >> >=20 >> >SET FEATURES (opcode 9) feature 0xb is indeed async event=20 >> >configuration.=20 >> >0x31f is:=20 >> >SMART WARNING for available spares (0x1)=20 >> >SMART warning for temperature (0x2)=20 >> >SMART WARNING for device reliability (0x4)=20 >> >SMART WARNING for being read only (0x8)=20 >> >SMART WARNING for volatile memory backup (0x10)=20 >> >Namespace attribute change events (0x100)=20 >> >Firmware activation events (0x200)=20 >> >=20 >> >I wonder which one of those it doesn't like. My reading of the standard= =20 >> >suggests that those should always be supported for a 1.2 and later=20 >> >drive... Thought maybe with the possible exception of the volatile=20 >> >memory backup, so let me do some digging here...=20 >> >=20 >> >We can get the last two items from OAES field of the controller=20 >> >identificaiton data. This is bytes 95:92, which if I'm counting right= =20 >> >is the last word on the 040: line in the nvmecontrol identify -x nvmeX= =20 >> >command:=20 >> >=20 >> >040: 4e474e4b 30303150 000cca07 00230000 00010200 005b8d80 0030d400=20 >> >00000100 >> >> >-----------------------------------------------------------------------= -----------------------------------^^^^^^^^^ >> >> On my system: >> >> 040: 31564456 30373130 5cd2e400 00000500 00010200 001e8480 002dc6c0=20 >> 00000200 >> > >Yea, 0x200 and we send 0x300, so maybe that's the cause of the message.... With the patch you sent, the message is gone from dmesg. Thank you. I didn't check (because I don't know how), but I assume that everything=20 else stayed the same. If, as you said above, these features should be supported per ithe=20 standard, but aren't, perhaps it would be worth printing a warning=20 (maybe under verbose boot)? But maybe it is too much hassle. Thanks anyway, and perhaps you may commit the patch you sent me. Thanks, Matteo --n3rvye4kcg25rgka Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJHBAABCgAxFiEEa9uKZL0hP4E8Nl5vGwL9SVQlVQEFAmKmA68TGGhrcHM6Ly9w Z3AubWl0LmVkdQAKCRAbAv1JVCVVATd6D/wMChf63H5IFXmib1M/bS8j9H6hBt/P +/eW+dBLrOztbKJunCg8Ny3MgtnttGK+RyzmIYRCJPS+bFMWBjLsLczH19BDcBXw OyJWdADZBtTPelnydC+Z3hYJnnl1WgklZRsHoJvkls+q2JdBKS0COMf7v3tIces1 nXPQkL0MJajYs9NE/t1VCa7y7IWP0sHnnzPZZAb+488ksdY9LZ5TwLMj1hhMwWtK vciApaq4Tfgl+BLY3TuaJzA/rZPYujB2vaPQCC6s4w2WHGzYfdaRbvVUwlFjGGwV QMTKiwsld6LjbFYkrpAodXCFwQO2ax0Sg8PnFSQwFDzSVO6fgFm31DFQK9rZLiRP 6fiCNa6wvE/dSf48BSmeZRgtYmyzS2BRByD/aOgw4dB9I+SKXYvlZBLCHLasmpmp G54IQiAKsEZw1wm6vLdvkfk4Hqt7/lF5PKitOLTOKh2Qgp7E/7w6gzzKqJbTNoAM Bj6xSKToLf4B0GyI7B1h1xpuu6stzx2E6kGYVQJDWx3x+IpYzY3ejT4NlY4IYGVL FEgfFSibJ6uj+HRL9ljHSsQSeTZ/9LGMN9GB0S3HTA743WkL73ZPz/uJMQljxWbK AQQD1b4/5PtAb3hyVOcklfxGuxHcrB3fvOMwDGmGpDGGR8w8/azw/SGd+0ZJLdrc AocQp+r8ZhiDaQ== =rGdl -----END PGP SIGNATURE----- --n3rvye4kcg25rgka--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220612151821.3a2fkfsqlr7ro7gf>