Date: Thu, 22 Feb 2018 18:52:25 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: "O. Hartmann" <ohartmann@walstatt.org> Cc: current <current@freebsd.org> Subject: Re: top: sysctl(vfs.bufspace...) expected 8, got 4 Message-ID: <CAGudoHE3EeA7njY20cPCz=kR9CJ-U87vSsP1%2BK5wtLa=QC73BA@mail.gmail.com> In-Reply-To: <20180222184218.2da3db1a@thor.intern.walstatt.dynvpn.de> References: <CAG6CVpUxXgNe1ZoXrzthPcgO=SwDkg-4f-NyME=GTbvdLCiUjw@mail.gmail.com> <201802211818.w1LII7fh087166@pdx.rh.CN85.dnsmgr.net> <CACNAnaGuCT%2B0R3zeHbB=YEXu074f38JWLkJ8OrZAQ0boXrXTjw@mail.gmail.com> <20180221200551.718ab72f@thor.intern.walstatt.dynvpn.de> <20180222184218.2da3db1a@thor.intern.walstatt.dynvpn.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 22, 2018 at 6:41 PM, O. Hartmann <ohartmann@walstatt.org> wrote:
> Am Wed, 21 Feb 2018 20:05:24 +0100
> "O. Hartmann" <o.hartmann@walstatt.org> schrieb:
>
> > On CURRENT ( 12.0-CURRENT FreeBSD 12.0-CURRENT #196 r329679: Tue Feb 20
> 23:06:15 CET
> > 2018 amd64) I'm honored by this nice bug when calling top:
> >
> > top: sysctl(vfs.bufspace...) expected 8, got 4
> >
> >
> > Regards,
> >
> > oh
>
> I still can not use "top", it quits with the error mentioned above. Whats
> is wrong with
> my setup?
>
>
Looks like a fallout from r329612.
Try this, untested:
diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c
index a2a1736a24f4..7cb6aa15ddc5 100644
--- a/sys/kern/vfs_bio.c
+++ b/sys/kern/vfs_bio.c
@@ -423,7 +423,7 @@ sysctl_bufspace(SYSCTL_HANDLER_ARGS)
lvalue = 0;
for (i = 0; i < clean_domains; i++)
lvalue += bdclean[i].bd_bufspace;
- return (sysctl_handle_int(oidp, &lvalue, 0, req));
+ return (sysctl_handle_long(oidp, &lvalue, 0, req));
}
#endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHE3EeA7njY20cPCz=kR9CJ-U87vSsP1%2BK5wtLa=QC73BA>