Date: Tue, 25 Apr 2017 14:26:06 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com>, John Baldwin <jhb@freebsd.org> Cc: rgrimes@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r317409 - head/contrib/tcpdump Message-ID: <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org> In-Reply-To: <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com> References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml Content-Type: multipart/mixed; boundary="8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Benjamin Kaduk <bjkfbsd@gmail.com>, John Baldwin <jhb@freebsd.org> Cc: rgrimes@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Message-ID: <edda9d8c-118b-4b91-1b06-fdbcda786b9b@FreeBSD.org> Subject: Re: svn commit: r317409 - head/contrib/tcpdump References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com> In-Reply-To: <CAJ5_RoBgpHc-yO3QE3tpaDSU5i3btF6A_Mq7axG14W2uraBKwQ@mail.gmail.com> --8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/25/2017 1:38 PM, Benjamin Kaduk wrote: > On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin <jhb@freebsd.org > <mailto:jhb@freebsd.org>> wrote: >=20 >=20 > I do think that when referring to a Git hash the citation should > also include > something to identify which repository it came from. It doesn't > have to be a > URL per se (we just use 'NetBSD' for makefs, not a full URL to NetB= SD's > cvsweb), but it should be clear enough that one can find the > corresponding > repository. Probably that information belongs in 'Obtained From'. >=20 >=20 > Since Rodney asked and I already have the svn log up, here are some exi= sting > commits that are doing similar sorts of things: > r317267 is typical of the illumos/ZFS imports > though sometimes a full github URL is used, as in r316695 > r316665 pulls from Concurrency Kit (I think; CK was not expanded in the= > commit message :( ) > r315947 from libcxxrt > r315926 and a few previous revisions from dragonflybsd.git > r315745 from libcxxrt > r314435 again from CK >=20 > and we're not even out of 2017 yet. >=20 Plus if tcpdump were using SVN then we would refer to an SVN revision here. If it were using CVS then a CVS revision. Like this commit in FreeBSD: > -----------------------------------------------------------------------= - > r306349 | pfg | 2016-09-26 09:06:50 -0700 (Mon, 26 Sep 2016) | 7 lines > Changed paths: > M /head/lib/libc/db/hash/hash_page.c >=20 > hash(3): protect in-memory page when using cross-endianness. >=20 > When writing out pages in the "other endian" format, make a copy > instead of trashing the in-memory one. >=20 > Obtained from: NetBSD (CVS rev. 1.29) >=20 > -----------------------------------------------------------------------= - It is definitely more useful to note which repository and what VCS system the revision/hash/version refers to. But there's nothing inherently wrong about using a git hash. Github !=3D git. It is merely a= n interface to git and is not required to use any of the git repositories on it given another mirror or local checkout. If a project uses git as their official VCS then a git hash is the proper reference. --=20 Regards, Bryan Drewery --8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX-- --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJY/774AAoJEDXXcbtuRpfPqK8IAJa5cJknpC1utjzGN4oJbzU0 CRrKWxaP1Qujlu5yY1lYLmRn2X1k5poxQY6Pb5VeGx5H7b6eDJMnhLIx8mx8RMBe YFZ8oQ33Zh3ynsx6t5EXvaU8+oHOXS+xiHwgKVeHGsI75LQD/WEGgyKErRJjoK6D xuSdDZOAxEYekEoMr5mltZGkWqtj+dAPj9wyGZAFXrM1CmBKVbiOlWugZDbiXJOP fRw7tKr+2l0L6iWSzWcDjFIvOvKum2/VOj7zAwEhZha03JAS9+gzF0hRZ31tywLt odNLIw0trvG18Uxg/Qg4j7VdLzPLgMmDqP7HTeQX32qT4HwNa6W/3JEVBPgzVsM= =mFu4 -----END PGP SIGNATURE----- --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?edda9d8c-118b-4b91-1b06-fdbcda786b9b>