Date: Wed, 8 Oct 2014 22:39:29 +0200 From: Baptiste Daroussin <bapt@freebsd.org> To: Craig Rodrigues <rodrigc@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r272649 - head/contrib/byacc Message-ID: <20141008203928.GA2675@ivaldir.etoilebsd.net> In-Reply-To: <CAG=rPVcW=t=NDMzfusyZbL_=Eubtth3iFvf_bRo5rCjsMkjXCw@mail.gmail.com> References: <201410061443.s96Eh2Jn022718@svn.freebsd.org> <20141006144924.GB37670@ivaldir.etoilebsd.net> <CAG=rPVfJFMa8VrSco6VnEW3Lf%2BM6gm0e4f4KSH=rvYEEs2EJog@mail.gmail.com> <20141007223941.GT37670@ivaldir.etoilebsd.net> <CAG=rPVcW=t=NDMzfusyZbL_=Eubtth3iFvf_bRo5rCjsMkjXCw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 08, 2014 at 01:10:19PM -0700, Craig Rodrigues wrote: > On Tue, Oct 7, 2014 at 3:39 PM, Baptiste Daroussin <bapt@freebsd.org> wro= te: >=20 > > On Tue, Oct 07, 2014 at 02:02:34PM -0700, Craig Rodrigues wrote: > > > On Mon, Oct 6, 2014 at 7:49 AM, Baptiste Daroussin <bapt@freebsd.org> > > wrote: > > > > > > > > > > > Why a direct commit instead of a proper import of 20141005 version?= it > > > > would > > > > have imho been better, simpler and easier to maintain. > > > > > > > > > > Because according to Thomas Dickey, he did not fix all > > > the memory related problems in snapshot 20141005. Specifically there= are > > > still > > > some issues not fixed when realloc() is called. > > > I was going to wait for the next snapshot. > > > However, I wanted to get that one fix into FreeBSD to fix the kyua te= sts, > > > which have been failing under Jenkins. See: > > > https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-tests2/ > > > (see runs #10 and #11). > > > > In that case I will import the new one which has the fix (do you confir= m?) > > >=20 > According to http://invisible-island.net/byacc/CHANGES.html , the > 2014-10-06 has a fix > to address my concerns. However, this fix involves a lot of changes to t= he > code, > and I don't have time right now to audit everything. >=20 > There have been a lot of changes to the byacc code in the past few days. > The changes > are good bugfixes, but I would recommend auditing everything beore > importing the snapshot into FreeBSD. It has already been imported the only difference between the version in base since 2 days ago and the version upstream now is your change. regards, Bapt --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlQ1oQAACgkQ8kTtMUmk6EwlMgCfT7LDln4+rPctQbGewkV2eHLU qXoAoKLb8JXa6qOQ7QAikrnWbd6fzTkM =LImK -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141008203928.GA2675>