Date: 13 Feb 2003 23:29:08 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: "Mezz bsdforums.org" <reigncracks@hotmail.com> Cc: FreeBSD GNOME Users <gnome@freebsd.org> Subject: Re: Here's Lumiere 0.4 ports.. Message-ID: <1045196948.69226.32.camel@shumai.marcuscom.com> In-Reply-To: <F81RD88kRWBSCsIvSiS00024a2c@hotmail.com> References: <F81RD88kRWBSCsIvSiS00024a2c@hotmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Thu, 2003-02-13 at 22:58, Mezz bsdforums.org wrote:
> > > ========================
> > > .if !exists(/usr/local/bin/mplayer)
> > > BROKEN= "MPlayer doesn\'t exist!"
> > > BROKEN+= "You have to install MPlayer from /usr/ports/multimedia/mplayer
> > > first."
> > > .endif
> > > ========================
> >
> >a) You should never use fully-qualified paths like that. Instead, use
> >the ${LOCALBASE} or ${X11BASE} macros.
>
> I tried did that last night and recently, it doesn't work very well same as
> what full path does. I am not sure exactly why it doesn't work. I did
> "${LOCALBASE}/bin/mplayer", it will keep say it's broke when I already have
> mplayer installed. Do I need to put something speical inside the exists()?
You need to make sure this check goes after:
.include <bsd.port.pre.mk>
>
> >b) Why don't you add a RUN_DEPENDS on mplayer instead of doing the
> >BROKEN thing at all?
>
> Because, MPlayer has a lot of options to install it. So, I thought it would
> be good idea to force users to go to the ports and install by theirselves
> with extra options. Am I making any sense?
Yeah, but by doing this, you will never be able to build a package of
Lumiere. I recommend adding mplayer as a RUN_DEPENDS, and users can
then decide to build mplayer later with more options. There are
examples of this throughout the ports collection (gstreamer-plugins
being a nice GNOME example).
Joe
>
> Thanks,
> Mezz
>
> _________________________________________________________________
> The new MSN 8: smart spam protection and 2 months FREE*
> http://join.msn.com/?page=features/junkmail
>
>
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-gnome" in the body of the message
--
PGP Key : http://www.marcuscom.com/pgp.asc
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQA+THCUb2iPiv4Uz4cRAiPRAJ9t0+iub/3bwOkv+7B1SiSQyO4+kgCfbxr0
4wBqxe61+q9djMNVXZdIO9c=
=NbRN
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1045196948.69226.32.camel>