Date: Mon, 20 Feb 2017 19:42:28 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Bryan Drewery <bdrewery@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313878 - head/sys/kern Message-ID: <7da9caa5-d938-d2d0-1228-0e8897dc5632@FreeBSD.org> In-Reply-To: <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org> References: <201702171540.v1HFeOAs074991@repo.freebsd.org> <e7d7c961-ec3b-22bc-445e-abe56e421e5c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
FWIW, On 2/20/2017 7:24 PM, Bryan Drewery wrote: > On 2/17/2017 7:40 AM, Mateusz Guzik wrote: >> Author: mjg >> Date: Fri Feb 17 15:40:24 2017 >> New Revision: 313878 >> URL: https://svnweb.freebsd.org/changeset/base/313878 >> >> Log: >> mtx: get rid of file/line args from slow paths if they are unused >> >> This denotes changes which went in by accident in r313877. > I really wish people would just revert their changes and recommit them > properly. The 'svn blame' on the code in r313877 will never show the > commit message here (r313878). So a person would only find this > explanation if they read 'svn log' on the file, which in the case of > sys/kern/kern_mutex.c there are 273 commits for. Are we expected to > read 'svn log' (in the future) for all changes in the hopes that a later > commit happens to mention it? > > As someone who so often is 'svn blame'ing code to understand it better > and to track regressions, commits like this that explain other commits > might as well have never been done. As I mentioned in another thread, other svn configurations (ASF, for example) permit editing the log message: http://help.collab.net/index.jsp?topic=/faq/changelog.html Cheers, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7da9caa5-d938-d2d0-1228-0e8897dc5632>