Date: Sun, 23 May 2010 17:24:32 +0200 From: =?ISO-8859-1?Q?Ren=E9_Ladan?= <rene@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Max Brazhnikov <makc@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org, Dmitry Marakasov <amdmi3@amdmi3.ru>, cvs-ports@freebsd.org, Dima Panov <fluffy@freebsd.org> Subject: Re: cvs commit: ports/devel/cmake Makefile distinfo pkg-plist ports/devel/cmake-gui Makefile distinfo Message-ID: <AANLkTikoplNIVVw0d1nmim6jwr3Icw2HTJON3eX7bjJr@mail.gmail.com> In-Reply-To: <20100522111916.GB49597@FreeBSD.org> References: <200911291151.nATBpdsp044837@repoman.freebsd.org> <20100521170958.GA24679@FreeBSD.org> <4BF6EB8A.6020005@freebsd.org> <201005221405.42362.makc@freebsd.org> <20100522111916.GB49597@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
2010/5/22 Alexey Dokuchaev <danfe@freebsd.org>:
> On Sat, May 22, 2010 at 02:05:42PM +0400, Max Brazhnikov wrote:
>> On Fri, 21 May 2010 22:22:34 +0200, Rene Ladan wrote:
>> > > Yeah, I've also had to explicitly provide path to wxgtk2-2.8-config for
>> > > my CMake-based ports as well. šProbably some sort of hack we used to
>> > > employ for sdl12-config is in order; creating symlink seems bad since
>> > > target might be something other than wxgtk2-2.8-config, leading to
>> > > potential conflicts. šWe have a long record of dealing with local
>> > > differences from the rest of the [GNU/OSS] world in a sane ways. š:-)
>> > >
>> > I've sent a patch for this with ports/146805
>>
>> With this patch cmake/wx-based ports will always try to build with wx-2.8
>> when multiple wx ports are installed, disregarding what ports/user request.
>>
Erm yes, I overlooked this situation when writing the patch.
>> Wouldn't better to pass ${WX_CONFIG} for CMAKE_ARGS in bsd.wx.mk, as it does
>> already for CONFIGURE_ARGS?
>
> Hmm. šActually, that's pretty much what people do with their ports to
> hack around this problem (line from one of mine):
>
> šCMAKE_ARGS= š -DwxWidgets_CONFIG_EXECUTABLE="${WX_CONFIG}"
>
> Maybe we should just += this value to CMAKE_ARGS when appropriate (read:
> when USE_WX) and be done this it?
>
In this case, can you just use the simple CMakeLists.txt as shown
earlier in this thread and the PR ?
Rene
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTikoplNIVVw0d1nmim6jwr3Icw2HTJON3eX7bjJr>