Date: Mon, 10 Nov 2003 17:30:22 -0800 From: Alfred Perlstein <alfred@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/nfsclient nfs_vnops.c Message-ID: <20031111013022.GL33733@elvis.mu.org> In-Reply-To: <200311110032.hAB0WkJi073981@repoman.freebsd.org> References: <200311110032.hAB0WkJi073981@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This will allow interested parties to smp'ify NFS, otherwise you need a global lock. It also will allow us to remove a lot of the hacks needed to deal with the fake exclusivity of the locking that was going on here. This could be MFC'd but I don't see the point right now. * Alfred Perlstein <alfred@FreeBSD.org> [031110 16:33] wrote: > alfred 2003/11/10 16:32:46 PST > > FreeBSD src repository > > Modified files: > sys/nfsclient nfs_vnops.c > Log: > Stop using shared locks for nfs vop locks. > > The reason this was done was to avoid a race to the root when an > NFS server went down. However a semi-recent change to the way that > the kernel's lookup() routine traverses mount points prevents this. > > Rev 1.39 of vfs_lookup.c changed the ordering of locks such that we > aquire a shared lock on the mount point being accessed and then drop > the directory vnode lock before requesting the target lock. > > With that in place we no longer need shared locks for NFS to prevent > race to the root lockups. > > Revision Changes Path > 1.214 +0 -3 src/sys/nfsclient/nfs_vnops.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031111013022.GL33733>