Date: Wed, 15 Apr 2009 22:58:15 +0200 From: Ed Schouten <ed@80386.nl> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191114 - head/sys/pc98/cbus Message-ID: <20090415205815.GA58540@hoeg.nl> In-Reply-To: <200904151632.41653.jhb@freebsd.org> References: <200904151958.n3FJwfqD052982@svn.freebsd.org> <200904151632.41653.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--OXfL5xGRrasGEqWY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello John, * John Baldwin <jhb@freebsd.org> wrote: > When I performed similar changes in lpt(4) I stored the flags in si_drv2= =20 > instead of the minor number. You might want to do the same here so the= =20 > drivers are closer. I guess in the very far future we'll hopefully just get rid of dev2unit() and allow the struct field that stores the unit number (si_drv0) to be used by the drivers directly. An advantage of the unit number is that it's an integer type, unlike si_drv1 and si_drv2. I guess it's good to just leave it the way it is right now, because it was the least intrusive way to fix it like this and best of all, if I ever get the chance to remove dev2unit(), I'm forced to let it use si_drv0 instead of keeping evil casts from/to pointers. --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --OXfL5xGRrasGEqWY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAknmSmcACgkQ52SDGA2eCwX2GQCfbuLU+H7LUa/Cir3Fr/lPBmFS 8dwAnjZwzxY2LTqag+/IuZJDr1GCms7Y =PE5l -----END PGP SIGNATURE----- --OXfL5xGRrasGEqWY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090415205815.GA58540>