Date: Wed, 27 May 2009 13:40:02 GMT From: Pavel Gorshkov <gorshkov.pavel@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup Message-ID: <200905271340.n4RDe2dD043875@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/134474; it has been noted by GNATS.
From: Pavel Gorshkov <gorshkov.pavel@gmail.com>
To: bug-followup@FreeBSD.org
Cc:
Subject: Re: ports/134474: deskutils/wmpinboard segfaults on startup
Date: Wed, 27 May 2009 17:12:04 +0400
--NzB8fVQJ5HfG6fxh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Fixed. XCreateIC() was getting 4 zero bytes + 4 extra bytes of
garbage instead of the NULL pointer needed to terminate the va_list.
--NzB8fVQJ5HfG6fxh
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="wmpinboard-missing-sentinel.diff"
--- src/xmisc.c.orig 2009-05-27 17:03:25.000000000 +0400
+++ src/xmisc.c 2009-05-27 16:42:40.000000000 +0400
@@ -204,7 +204,7 @@
return;
}
- if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, 0) || !xim_styles) {
+ if (XGetIMValues(xim, XNQueryInputStyle, &xim_styles, NULL) || !xim_styles) {
XCloseIM(xim);
#ifdef DEBUG_IC
fprintf(stderr, "Input method doesn't support any style.\n");
@@ -258,7 +258,7 @@
}
InputContext = XCreateIC(xim, XNInputStyle, input_style,
- XNClientWindow, win, XNFocusWindow, win, 0);
+ XNClientWindow, win, XNFocusWindow, win, NULL);
if (!InputContext) {
XCloseIM(xim);
--NzB8fVQJ5HfG6fxh--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200905271340.n4RDe2dD043875>