Date: Thu, 19 Sep 2002 22:15:05 +0100 From: Mark Murray <mark@grondar.za> To: Bruce Evans <bde@zeta.org.au> Cc: arch@FreeBSD.ORG Subject: Re: More lint work for share/mk/ (review, please) Message-ID: <200209192115.g8JLF57s003495@grimreaper.grondar.org> In-Reply-To: <20020920054221.E2677-100000@gamplex.bde.org> ; from Bruce Evans <bde@zeta.org.au> "Fri, 20 Sep 2002 06:29:10 %2B1000." References: <20020920054221.E2677-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > NOLINT, and this is supposed to be put into individual Makefiles
> > to kill copious lint output from code out of our control (like
> > GNU stuff, other contrib/ code and so on).
>
> Wouldn't `.undef WANT_LINT' in individual Makefiles be better than
> another knob?
Maybe. I dunno. There is no precedent for the .undef form, whereas
we have lots for the WANT_* or NO_* type of knobs. Seems yukky to
do something that requires another syntax.
> % - ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC} | more 2>&1
> % + ${LINT} ${LINTFLAGS} ${CFLAGS:M-[DIU]*} ${.ALLSRC}
>
> I wonder what this pipeline is for. I once thought that it was to combine
> stdout with stderr to work around the bug that lint prints some messages
> on stderr, but it is wrong for that -- the correct way to combine stdin
> with stderr is "2>&1" before any pipe.
This got discussed to death last time. It is minor and mostly irrelevant;
its here for consistency with another similar removal. Locally I just
put it back in the .mk file as
lint:
${LINT} .... ${.ALLSRC} 2>&1 | cat
so I can
# make lint | less
I don't feel stronly enough to discuss this any further. Take it
out, leave it in. Either way suits me. :-)
> % -CFLAGS += -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
> % +CFLAGS += -ansi -pedantic -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wno-long-long
> % . endif
> % . if ${WARNS} > 1 && ${WARNS} < 5
> % # XXX Delete -Wuninitialized by default for now -- the compiler doesn't
>
> No thanks. This breaks gcc's warning. -ansi means C90 (-std=c89), and
> this standard doesn't have long long. Of course, programs not written in
> C90 can't be compiled with this warning level.
Oops! Mistake. This was not intended for the LINT commit! This is
strictly local.
> Non-POSIX rules shouldn't be duplicated in the POSIX section.
OK.
Thanks!
M
--
o Mark Murray
\_
O.\_ Warning: this .sig is umop ap!sdn
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209192115.g8JLF57s003495>