Date: Wed, 10 Aug 2022 16:53:06 +0200 From: Rodrigo Osorio <ros@bebik.net> To: ports@freebsd.org Subject: Re: [www/chimeracord] port of my unofficial discord client Message-ID: <12183ec9-f711-5fd8-8289-f1d9ef516451@bebik.net> In-Reply-To: <FUdEBJusomHbsAZT7CCmme6I3-C56Zbu4t1wNyM_MujgQ_DynzReLwhc_JQg2ot-WcpV-vqNiNxxmsS6KzEWYNbGsZAha7a6u3WmsqQVUtk=@protonmail.com> References: <FUdEBJusomHbsAZT7CCmme6I3-C56Zbu4t1wNyM_MujgQ_DynzReLwhc_JQg2ot-WcpV-vqNiNxxmsS6KzEWYNbGsZAha7a6u3WmsqQVUtk=@protonmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------70ywaqr80SWJiJZr2WhlF8n3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/10/22 15:56, Fernando wrote: > I made an unofficial discord using electron and wanting to put it in > the official freeBSD repositories, > it stages, installs, and packages with no issues, I even have a > pre-built binary, > > > git (port): https://github.com/RoboChimera/ChimeraCordBSDPORTS > git (source): https://github.com/RoboChimera/ChimeraCord Hi Fernando, Thanks for you submission, I take a quick look and see a couple of missing stuffs such as the distfile location. To make it simple I chose to use the the github facility. Just by adding the following lines after the BUILD_DEPENDS bloc: * USE_GITHUB= yes GH_ACCOUNT= RoboChimera GH_PROJECT= ChimeraCord GH_TAGNAME= 1ed63ff After that there is some changes to do in the install script, to start, no need to perform the git clone, USE_GITHUB does it for you. After that there is a couple of fixes to do in the install process when you can use variable such as WRKSRC. I recommend you to take a look at the porter handbook, to see how to improve your port (https://docs.freebsd.org/en/books/porters-handbook) Also, you can submit a review of your port using our phabricator (https://reviews.freebsd.org/) the details about how to use are here: https://wiki.freebsd.org/Phabricator. Happy hacking, -- rodrigo --------------70ywaqr80SWJiJZr2WhlF8n3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body> <div class="moz-cite-prefix">On 8/10/22 15:56, Fernando wrote:<br> </div> <blockquote type="cite" cite="mid:FUdEBJusomHbsAZT7CCmme6I3-C56Zbu4t1wNyM_MujgQ_DynzReLwhc_JQg2ot-WcpV-vqNiNxxmsS6KzEWYNbGsZAha7a6u3WmsqQVUtk=@protonmail.com"> <meta http-equiv="content-type" content="text/html; charset=UTF-8"> <div style="font-family: Arial; font-size: 14px;">I made an unofficial discord using electron and wanting to put it in the official freeBSD repositories, <br> </div> <div style="font-family: Arial; font-size: 14px;">it stages, installs, and packages with no issues, I even have a pre-built binary,</div> <div style="font-family: Arial; font-size: 14px;"><br> </div> <div style="font-family: Arial; font-size: 14px;"><br> </div> <div style="font-family: Arial; font-size: 14px;">git (port): <span><a target="_blank" rel="noreferrer nofollow noopener" href="https://github.com/RoboChimera/ChimeraCordBSDPORTS" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/RoboChimera/ChimeraCordBSDPORTS</a></span><br>; </div> <div style="font-family: Arial; font-size: 14px;">git (source): <span><a target="_blank" rel="noreferrer nofollow noopener" href="https://github.com/RoboChimera/ChimeraCord" moz-do-not-send="true" class="moz-txt-link-freetext">https://github.com/RoboChimera/ChimeraCord</a></span><br>; </div> </blockquote> <p>Hi Fernando,</p> <p>Thanks for you submission, I take a quick look and see<br> a couple of missing stuffs such as the distfile location.<br> To make it simple I chose to use the the github facility.</p> <p>Just by adding the following lines after the BUILD_DEPENDS bloc:</p> <ul class="list-style-none f6" style="box-sizing: border-box; padding-left: 0px; margin-top: 0px; margin-bottom: 0px; font-size: 12px !important; list-style: none !important; color: rgb(36, 41, 47); font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Helvetica, Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji"; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;"> <li class="d-inline-block mt-1 mr-2 text-mono" style="box-sizing: border-box; margin-top: 4px !important; margin-right: 8px !important; font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, "Liberation Mono", monospace !important; display: inline-block !important;">USE_GITHUB= yes<br> GH_ACCOUNT= RoboChimera<br> GH_PROJECT= ChimeraCord<br> GH_TAGNAME= 1ed63ff</li> </ul> <p>After that there is some changes to do in the install script,<br> to start, no need to perform the git clone, USE_GITHUB does it<br> for you.</p> <p>After that there is a couple of fixes to do in the install process<br> when you can use variable such as WRKSRC.<br> </p> <p><br> I recommend you to take a look at the porter handbook, to see how to<br> improve your port (<a class="moz-txt-link-freetext" href="https://docs.freebsd.org/en/books/porters-handbook">https://docs.freebsd.org/en/books/porters-handbook</a>)<br>; </p> <p>Also, you can submit a review of your port using our phabricator<br> (<a class="moz-txt-link-freetext" href="https://reviews.freebsd.org/">https://reviews.freebsd.org/</a>) the details about how to use are here:<br> <a class="moz-txt-link-freetext" href="https://wiki.freebsd.org/Phabricator">https://wiki.freebsd.org/Phabricator</a>.</p>; <p>Happy hacking,<br> -- rodrigo<br> </p> </body> </html> --------------70ywaqr80SWJiJZr2WhlF8n3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?12183ec9-f711-5fd8-8289-f1d9ef516451>