Date: Tue, 15 Feb 2011 16:02:24 +0200 From: Nikolay Denev <ndenev@gmail.com> To: freebsd-net@freebsd.org Subject: ng_ether and vlan interfaces Message-ID: <D275511D-0502-48ED-9186-EF4BF42B372E@gmail.com>
next in thread | raw e-mail | index | archive | help
Hi,
When trying to use ng_ether with vlan interfaces using the naming sheme ${parent_if}.${vlan_tag}
it produces the following warning :
ng_ether_attach: can't name node ix0.512
And the newly created netgraph node stays <unnamed>.
This is due to the following check in sys/netgraph/ng_base.c:ng_name_node() :
/* Check the name is valid */
for (i = 0; i < NG_NODESIZ; i++) {
if (name[i] == '\0' || name[i] == '.' || name[i] == ':')
break;
}
Do we really do not want to allow dot in the name?
If it's not an option to allow the dot, probably it would be better to replace it with
underscore.
I can provide a patch if the change is acceptable.
Cheers,
Nikolay
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D275511D-0502-48ED-9186-EF4BF42B372E>