Date: Tue, 11 Apr 2017 15:20:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218564] x11/lightdm: Use correct replacement for clearenv() Message-ID: <bug-218564-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218564 Bug ID: 218564 Summary: x11/lightdm: Use correct replacement for clearenv() Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: woodsb02@freebsd.org After x11/lightdm was committed to the ports tree, jbeich pointed out that = the function used to clear the process environment in place of clearenv() does = not look right: https://lists.freebsd.org/pipermail/svn-ports-head/2016-December/135993.html The issue with the BSDs not having clearenv() was first raised on the Light= DM bug reporting system related to NetBSD here: https://bugs.launchpad.net/lightdm/+bug/999714 There was discussion about which of the following should be the replacement: putenv ("environ=3DNULL"); environ =3D NULL; The latter option was ultimately committed to LightDM here: http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/revision/1517 However the FreeBSD port was committed with a patch to change the replaceme= nt code to the former option. According to the NOTES section in the Linux kernel manpage for clearenv(3): On systems where clearenv() is unavailable, the assignment environ =3D NULL; will probably do. http://man7.org/linux/man-pages/man3/clearenv.3.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-218564-13>