Date: Thu, 2 Mar 2023 04:28:07 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently Message-ID: <ZAAl1xad3s/Wqk22@FreeBSD.org> In-Reply-To: <202303020300.32230wHb032429@gitrepo.freebsd.org> References: <202303020300.32230wHb032429@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 02, 2023 at 03:00:58AM +0000, Kyle Evans wrote:
> commit 6b4ef4b16a6930d91d0d99c4ceb75cd43a7526c1
>
> daemon: use braces with 'if' consistently
> [...]
> ...
> diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c
> index edcdf3141fcc..f9c1f73e193c 100644
> --- a/usr.sbin/daemon/daemon.c
> +++ b/usr.sbin/daemon/daemon.c
> @@ -173,14 +173,16 @@ main(int argc, char *argv[])
> break;
> case 'l':
> logfac = get_log_mapping(optarg, facilitynames);
> - if (logfac == -1)
> + if (logfac == -1) {
> errx(5, "unrecognized syslog facility");
> + }
Not only that I don't quite understand how does this commit really
improve anything, but looks like it's badly formatted as well.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZAAl1xad3s/Wqk22>