Date: Tue, 11 Jan 2022 14:28:57 GMT From: Mark Johnston <markj@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 4905ce27b827 - stable/13 - mvneta: Unconditionally print an error message if mii_attach() fails Message-ID: <202201111428.20BESvBt092642@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=4905ce27b827fb618171f98e4b0cf17c7fb5f962 commit 4905ce27b827fb618171f98e4b0cf17c7fb5f962 Author: Mark Johnston <markj@FreeBSD.org> AuthorDate: 2022-01-04 14:42:34 +0000 Commit: Mark Johnston <markj@FreeBSD.org> CommitDate: 2022-01-11 14:28:33 +0000 mvneta: Unconditionally print an error message if mii_attach() fails The error message is useful for diagnosing mvneta_attach() failures. (cherry picked from commit ed166a0173247e267c507ebd0ec03cb04aaf49ee) --- sys/dev/neta/if_mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index debb4a922cbc..8b9135419736 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -735,10 +735,8 @@ mvneta_attach(device_t self) mvneta_mediastatus, BMSR_DEFCAPMASK, sc->phy_addr, MII_OFFSET_ANY, 0); if (error != 0) { - if (bootverbose) { - device_printf(self, - "MII attach failed, error: %d\n", error); - } + device_printf(self, "MII attach failed, error: %d\n", + error); ether_ifdetach(sc->ifp); mvneta_detach(self); return (error);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201111428.20BESvBt092642>