Date: Wed, 22 Oct 2014 10:39:33 -0600 From: Warner Losh <imp@bsdimp.com> To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r273417 - head Message-ID: <37EBD040-32F3-4096-B036-E93B51FCDBBD@bsdimp.com> In-Reply-To: <86mw8ocftw.fsf@nine.des.no> References: <201410212029.s9LKThT2074337@svn.freebsd.org> <86d29k28wh.fsf@nine.des.no> <22788EC4-3BDF-40F3-ACAC-FA686ED21154@bsdimp.com> <86iojco2oh.fsf@nine.des.no> <6287010D-9C54-4167-9784-84134080A419@bsdimp.com> <86mw8ocftw.fsf@nine.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_686944A9-1466-4C08-B7C8-5669BA822739 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Oct 22, 2014, at 8:57 AM, Dag-Erling Sm=F8rgrav <des@des.no> wrote: > Warner Losh <imp@bsdimp.com> writes: >> Dag-Erling Sm=F8rgrav <des@des.no> writes: >>> I would prefer calling this MK_ATF than MK_TESTS_SUPPORT, though. >>> The test framework is probably useful on its own. >> That would be a nicer name, but then we=92d lose the automatic = setting >> when MK_TESTS is enabled (unless we add another special case, which = is >> the opposite direction that I want to go in). How strongly do you = feel >> that=92s a better name? >=20 > Is _SUPPORT magic? I didn't know. I guess MK_TESTS_SUPPORT is good > enough, especially if it's on by default. It is magic. Though one can replicate similar magic with MK_TESTS and = MK_ATF if one wanted to do so (there=92s a second list of defaults based on = settings that have unrelated names), though that list is much smaller and used in much more = obscure areas of the system. Warner --Apple-Mail=_686944A9-1466-4C08-B7C8-5669BA822739 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUR93FAAoJEGwc0Sh9sBEAmMIP/28CtvJpbHmSxaHSti+ZXvHW pB7uxlUVFDWq84qY9OQXSwsBNx4oSHnZUc9Q9p+f8WYLJ1j5/4Q63mPA+yxA8aPq /L/o5IS/D/asbYTKqzaCYfSlE9tDCzshDHgrGl1WJjFckw6NvW0p4MH0/ZFJIEO+ jPgarWruiurxPRybjY8mlX7ZwcJEpkclGcH9aVHsIxFy5ZpBC+3UfrwyFjm1lUhU bPmlXlGzLi14cSuWvRDqhyBx9+N33/KRzSE+DX4V78oj7uaU+kJ4Z3qVzdRt5pfB +D+KgJgWrc1uLB9hIpUCLWTjczFJTp0mrB7oeBxa5dZreglF+5bomMP1iVFeY0mJ Ycr0VqCz8SSyOncqODD11iNhZkxgELdX3SA58L2FUFL8JuXCr/L8DR6X30z2KVC8 qkZjhfg5vimbXitF8jUyNfdAv3lne5QciAgpYzebXQF6f3zxTZ8ZFkB3wBJerbVN 1OfaLeHR+puZL46DH5Igzh90Lf1eHCcCzRir8PJVG7kYO6skHB4MJ5aoyYfLJJhL hD0ZBvGd+GLhlsKFbx7x2EXeYrsLufm3WcTxNlsLzn1p2ODjjhGK3vPotqdC8gnb ExexFfXJYJASZryic3IZhlSoqi8w+Zb5ni7cfKJr/6Hj3MKge9bpdwy8aBUxX9Qh S70P3fLoUfbrYMMcWa22 =8RsM -----END PGP SIGNATURE----- --Apple-Mail=_686944A9-1466-4C08-B7C8-5669BA822739--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?37EBD040-32F3-4096-B036-E93B51FCDBBD>