Date: Mon, 20 Dec 2021 17:28:50 +0000 From: Brooks Davis <brooks@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: Shawn Webb <shawn.webb@hardenedbsd.org>, Brooks Davis <brooks@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 45b48cbc2b58 - main - usb: real freebsd32 support for most ioctls Message-ID: <20211220172850.GA78726@spindle.one-eyed-alien.net> In-Reply-To: <c5c01975-fba7-a6ef-1b17-b6992146d27a@selasky.org> References: <202112172128.1BHLSvgR063035@gitrepo.freebsd.org> <20211218190800.2v7bzacypzhiguvz@mutt-hbsd> <4961aa77-848f-ab04-91aa-7526ebb0bdde@selasky.org> <c5c01975-fba7-a6ef-1b17-b6992146d27a@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 18, 2021 at 09:33:51PM +0100, Hans Petter Selasky wrote: > On 12/18/21 21:13, Hans Petter Selasky wrote: > > On 12/18/21 20:08, Shawn Webb wrote: > >> +#ifdef COMPAT_FREEBSD32 > >> +?????? hgd =3D (struct hidraw_gen_descriptor *)addr; > >=20 > > Looks like this line should be moved before the COMPAT_FREEBSD32 ifdef.= =20 > > I'll let Brooks fix this. > >=20 > > --HPS > >=20 >=20 > I've made two fixes. Brooks, please check these patches too: >=20 > https://cgit.freebsd.org/src/commit/?id=3D34077a8ed39f40da4b7faffff0b112f= 1dcb62ab4 >=20 > https://cgit.freebsd.org/src/commit/?id=3D8b60419b798ae9049988c529e6af3f3= 13a5cce55 Thank you for making these fixes. I'm a bit surprised neither of these showed up on amd64. :( -- Brooks --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJhwL1RAAoJEKzQXbSebgfAVHYIAKS4V23PSu2VDqRcecXfYvUr +E9DlWzf/JRSn4VY5vNcrzXAULRJpb5+KkcIUbinfY18KvNRduUOiwTvO6Rij0II R0f61IbkTX0A5ikXqx5Uz9EGU/q0sYC5Mp812kyuFaVZvos8I4nqv9bE1ri7vGFI XbV9Es2nM3+4Ff9S9hT5UI/R+Q3qbrZ1NpzmKkk6UYbq+qEahi6llYPWURggsSsP ip707yYtmCnb+/wznHTkcUOliOwsDL7L/V/3LD8jO2QBN7JwonxxRVIIz2L/0DG4 G1cvEeBsp/ZdEEjT+Q/ZAks7M/YWLGfQgXlrTr2CtT8+XNjDZwrn/uZyd+/Jnc0= =/PKg -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211220172850.GA78726>