Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 3 Oct 1998 13:49:16 +0100 (BST)
From:      Doug Rabson <dfr@nlsystems.com>
To:        Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Cc:        Brian Somers <brian@Awfulhak.org>, luigi@freebsd.org, cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/i386/isa/snd CARDS README ad1848.c dmabuf.c mss.h sb_dsp.c sbcard.h sound.c sound.h
Message-ID:  <Pine.BSF.4.01.9810031348270.8007-100000@herring.nlsystems.com>
In-Reply-To: <199810030939.KAA00766@labinfo.iet.unipi.it>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 3 Oct 1998, Luigi Rizzo wrote:

> > > luigi       1998/10/02 10:26:38 PDT
> > > 
> > >   Modified files:
> > >     sys/i386/isa/snd     CARDS README ad1848.c dmabuf.c mss.h 
> > >                          sb_dsp.c sbcard.h sound.c sound.h 
> ...
> > This seems to break with ``controller pnp0'' (in my case anyway).
> 
> what exactly breaks ? I had this code compiled and working on a
> 980925 SNAP with a PnP sound card (unless i did some mistake when
> applying the patchfile... not unlikely when doing interactive work
> with 20% loss...)

There is a problem with a duplicated case in a switch statement in
ad1848.c:

Index: ad1848.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/isa/snd/ad1848.c,v
retrieving revision 1.12
diff -u -r1.12 ad1848.c
--- ad1848.c	1998/10/02 17:26:36	1.12
+++ ad1848.c	1998/10/03 11:18:34
@@ -1487,7 +1487,6 @@
 
 	case 0x3500630e:        /* CS4236 */
 	case 0x3600630e:        /* CS4236 */
-	case 0x3500630e:	/* CS4236B */
 	    tmp_d.bd_id = MD_CS4236 ;
 	    break;
 

--
Doug Rabson				Mail:  dfr@nlsystems.com
Nonlinear Systems Ltd.			Phone: +44 181 951 1891
					Fax:   +44 181 381 1039




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9810031348270.8007-100000>