Date: Tue, 7 Apr 1998 01:00:01 -0700 (PDT) From: Matthew Dillon <dillon@backplane.com> To: freebsd-bugs Subject: Re: kern/6212: Two bugs with MFS filesystem fixed, two features added Message-ID: <199804070800.BAA14288@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/6212; it has been noted by GNATS.
From: Matthew Dillon <dillon@backplane.com>
To: Peter Wemm <peter@netplex.com.au>
Cc: freebsd-gnats-submit@hub.FreeBSD.ORG
Subject: Re: kern/6212: Two bugs with MFS filesystem fixed, two features added
Date: Tue, 7 Apr 1998 00:58:42 -0700 (PDT)
:Hmm! Now this is interesting, I'd never thought of trying that before.
:
:Although, I'm puzzled why the msync() is needed at all, since it's just a
:mmap'ed file. Perhaps there is some new lurking problem with synchronizing
:of mmap'ed files... :-/
Yah, this is what happens: I have a workstation with 64MB of ram,
*no swap* configured, and several file-over-NFS-backed MFS
filesystems.
Without that msync() hack, the RSS for the mfs processes continues to
build until the machine runs out of memory. If I 'sync' I'm ok ... it
writes out the dirty pages. If I don't, the machine barfs when it
runs out of memory. When I added the msync hack to the mfs kernel code,
that also appeared to fix the problem. If I don't sync and don't msync,
the MFS filesystem's pages stay dirty and are never synchronized with
their backing store.
:Can you please do us a favour and supply a context or unified diff?
:ie: 'cvs diff -u' Your patch could then be automatically applied rather
:than having to guess the context by hand.
Ah! cvs diff -u. ok. should I bother resubmitting this bug report or
can I just start doing that in the future ?
-Matt
:> Index: mkfs.c
:> ===================================================================
:> RCS file: /src/FreeBSD-CVS/ncvs/src/sbin/newfs/mkfs.c,v
:> retrieving revision 1.21
:> diff -r1.21 mkfs.c
:> 42a43
:> > #include <sys/stat.h>
:> 108a110
:> > extern int skipnewfs;
:> 181c183,185
:> < fd = open(filename,O_RDWR|O_TRUNC|O_CREAT,0644);
:> ---
:> > struct stat st;
:> >
:> > fd = open(filename,O_RDWR|O_CREAT,0644);
:
:Cheers,
:-Peter
:--
:Peter Wemm <peter@netplex.com.au> Netplex Consulting
:
:
:
Matthew Dillon Engineering, BEST Internet Communications, Inc.
<dillon@backplane.com>
[always include a portion of the original email in any response!]
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804070800.BAA14288>