Date: Sat, 13 Mar 2004 11:10:10 +0100 From: Alexander Leidinger <Alexander@Leidinger.net> To: cvs-src@freebsd.org Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/boot/arc/include arcfuncs.h src/sys/boot/i386/boot2 boot2.c src/sys/dev/aic7xxx/aicasm aicasm.c iir.h src/sys/dev/isp ispvar.h src/sys/dev/mcd mcdreg.h ... Message-ID: <20040313111010.6493143f@Magellan.Leidinger.net> In-Reply-To: <20040312224630.GG35475@elvis.mu.org> References: <20040312214545.7F3C216A4FA@hub.freebsd.org> <20040312223315.GE4588@ip.net.ua> <20040312224630.GG35475@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 12 Mar 2004 23:46:30 +0100
Maxime Henrion <mux@freebsd.org> wrote:
> It would be even better IMHO if you had used __GNUC_PREREQ__ in other
> files, to simplify all those tests.
It would be better to change this to feature tests and set the
appropriate defines at the beginning depending on the compiler used.
This way you only have to check the compiler once. This was suggested to
me by Matthew Dillon a while ago, but I think such a change should be
separate from the icc change, as it makes it more obvious what happens
in each change (so it's more easy to review).
Bye,
Alexander.
--
I will be available to get hired in April 2004.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040313111010.6493143f>