Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 Apr 2015 10:16:09 -0700
From:      Garrett Cooper <yaneurabeya@gmail.com>
To:        Josh Paetzel <jpaetzel@FreeBSD.org>
Cc:        "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>
Subject:   Re: svn commit: r281112 - head/etc/rc.d
Message-ID:  <F97AB59E-6C84-47D8-84D6-AF8DA0055515@gmail.com>
In-Reply-To: <201504051709.t35H9xG3036827@svn.freebsd.org>
References:  <201504051709.t35H9xG3036827@svn.freebsd.org>

index | next in thread | previous in thread | raw e-mail

Hi Josh,

> On Apr 5, 2015, at 10:09, Josh Paetzel <jpaetzel@FreeBSD.org> wrote:
> 
> Author: jpaetzel
> Date: Sun Apr  5 17:09:58 2015
> New Revision: 281112
> URL: https://svnweb.freebsd.org/changeset/base/281112
> 
> Log:
>  Bug fixes and feature adds
> 
>  - Remove extranious echo that breaks puppet
>  - Handle restarts of multiple pflog devices correctly
>  - Add the ability to perform actions on specific pflog devices.
> 
>  PR:    199150
>  Submitted by:    jason.unovitch@gmail.com
>  MFC after:    3 days
> 
> Modified:
>  head/etc/rc.d/pflog
> 
> Modified: head/etc/rc.d/pflog
> ==============================================================================
> --- head/etc/rc.d/pflog    Sun Apr  5 16:35:13 2015    (r281111)
> +++ head/etc/rc.d/pflog    Sun Apr  5 17:09:58 2015    (r281112)
> @@ -24,30 +24,30 @@ pflog_prestart()
> {
>    load_kld pflog || return 1
> 
> +    # create pflog_dev interface if needed
> +    if ! ifconfig $pflog_dev > /dev/null 2>&1; then
> +        if ! ifconfig $pflog_dev create; then
> +            warn "could not create $pflog_dev."
> +            return 1
> +        fi
> +    fi

Is a character device created for pflog?

> +
>    # set pflog_dev interface to up state
>    if ! ifconfig $pflog_dev up; then
>        warn "could not bring up $pflog_dev."
>        return 1
>    fi
> 
> +    # -p flag requires striping pidfile's leading /var/run and trailing .pid
> +    pidfile=$(echo $pidfile | sed -e 's|/var/run/||' -e 's|.pid$||')
> +

Could this use pgrep with a custom pidfile?

Thanks!

help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F97AB59E-6C84-47D8-84D6-AF8DA0055515>