Date: Tue, 6 Jan 2004 14:31:06 -0600 From: "Jacques A. Vidrine" <nectar@FreeBSD.org> To: Stefan Farfeleder <stefan@fafoe.narf.at> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/posix1e acl_delete_entry.c Message-ID: <20040106203106.GC46611@madman.celabo.org> In-Reply-To: <20040106201801.GA1348@wombat.fafoe.narf.at> References: <200401061843.i06IhV2L068324@repoman.freebsd.org> <20040106201801.GA1348@wombat.fafoe.narf.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 06, 2004 at 09:18:04PM +0100, Stefan Farfeleder wrote:
> @@ -61,9 +61,9 @@ acl_delete_entry(acl_t acl, acl_entry_t
> if ((acl->ats_acl.acl_entry[i].ae_tag == entry_d->ae_tag) &&
> (acl->ats_acl.acl_entry[i].ae_id == entry_d->ae_id)) {
> /* ...shift the remaining entries... */
> - while (i < acl->ats_acl.acl_cnt - 1)
> + for (; i < acl->ats_acl.acl_cnt - 1; ++i)
> acl->ats_acl.acl_entry[i] =
> - acl->ats_acl.acl_entry[++i];
> + acl->ats_acl.acl_entry[i];
>
> I think that last assignment should read:
>
> acl->ats_acl.acl_entry[i] = acl->ats_acl.acl_entry[i + 1];
*blush* Um, thanks!!!
--
Jacques Vidrine NTT/Verio SME FreeBSD UNIX Heimdal
nectar@celabo.org jvidrine@verio.net nectar@freebsd.org nectar@kth.se
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040106203106.GC46611>